[webkit-changes] [WebKit/WebKit] d526f3: Service Worker request is missing sec-fetch-dest

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d526f33ee5d447ab59659024d36f1170b377e97f
      
https://github.com/WebKit/WebKit/commit/d526f33ee5d447ab59659024d36f1170b377e97f
  Author: Youenn Fablet <you...@apple.com>
  Date:   2026-07-30 (Thu, 30 Jul 2026)

  Changed paths:
    A 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/soft-update-fetch-metadata.py
    A 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/soft-update-fetch-metadata.https-expected.txt
    A 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/soft-update-fetch-metadata.https.html
    M Source/WebCore/workers/service/server/SWServer.cpp
    M Source/WebCore/workers/service/server/SWServer.h

  Log Message:
  -----------
  Service Worker request is missing sec-fetch-dest
rdar://181909962
https://bugs.webkit.org/show_bug.cgi?id=318556

Reviewed by Chris Dumez.

When doing soft-update, the networking process is responsible to generate the 
update requests.
It was missing Sec-Fetch headers, that are typically added by web process.

We add Sec-Fetch headers and make sure to cover the 3 different cases:
- The main script
- Imported scripts
- Module loaded scripts.

We add a WPT test, which is passing in Chrome.
Firefox is also populating those headers but is not consistently setting 
Sec-Fetch-Dest to service worker.

Test: 
imported/w3c/web-platform-tests/service-workers/service-worker/soft-update-fetch-metadata.https.html

* 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/soft-update-fetch-metadata.py:
 Added.
(main):
(main.header_value):
* 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/soft-update-fetch-metadata.https-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/soft-update-fetch-metadata.https.html:
 Added.
* Source/WebCore/workers/service/server/SWServer.cpp:
(WebCore::addFetchMetadataHeaders):
(WebCore::SWServer::createScriptRequest):
(WebCore::SWServer::startScriptFetch):
(WebCore::SWServer::refreshImportedScripts):
* Source/WebCore/workers/service/server/SWServer.h:

Canonical link: https://commits.webkit.org/318237@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications