Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3f78363de00ec5adf1989421af24156ef4eb7f77
https://github.com/WebKit/WebKit/commit/3f78363de00ec5adf1989421af24156ef4eb7f77
Author: Ryan Haddad <[email protected]>
Date: 2026-07-30 (Thu, 30 Jul 2026)
Changed paths:
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/github_unittest.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py
Log Message:
-----------
[git-webkit] Handle non-JSON responses when printing user hints for GitHub
API errors
https://bugs.webkit.org/show_bug.cgi?id=320229
rdar://problem/183163928
Reviewed by Aakash Jain.
The improvement to the git-webkit user hints for GitHub API errors in
317643@main did not
account
for non-JSON responses. The 500 errors seen today caused the script to exit due
to
json.decoder.JSONDecodeError instead of printing the hint.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Bump version
to 0.15.4 since
webkitscmpy will now call the new Tracker.decode_json() functions
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py:
(Tracker.decode_json): Add helper that decodes the response body, returning {}
on invalid JSON.
(Tracker.request): Route the error-path message read through decode_json().
(Tracker.user): Ditto.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/github_unittest.py:
(TestGitHub.test_decode_json): Add new test.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Bump version to
7.0.4 and
require webkitbugspy 0.15.4.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
(PullRequests.create): Route parse_error() through Tracker.decode_json().
(PullRequests.update):
Ditto.
(GitHub._make_comment): Ditto.
(GitHub.review): Ditto.
(GitHub.graphql): Route the error-path message read through
Tracker.decode_json().
Canonical link:
https://flagged.apple.com:443/proxy?t2=dz5B9X4Uy9&o=aHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvMzE4MjYyQG1haW4=&emid=5bc32c63-bcef-4a72-8b11-a7669558a3fe&c=11
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
