Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4cf1ce000dad0bd6ebc8fa09c572997ce0a20b42
https://github.com/WebKit/WebKit/commit/4cf1ce000dad0bd6ebc8fa09c572997ce0a20b42
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-31 (Fri, 31 Jul 2026)
Changed paths:
M Source/WebCore/mathml/MathMLPresentationElement.cpp
M Source/WebCore/mathml/MathMLPresentationElement.h
Log Message:
-----------
Take a StringView in MathMLPresentationElement::parseMathMLLength
https://bugs.webkit.org/show_bug.cgi?id=320711
rdar://183698156
Reviewed by Chris Dumez and Frédéric Wang Nélar.
parseMathMLLength took a const String& only to immediately convert it to a
StringView and trim it, unlike its two sibling helpers parseNumberAndUnit and
parseNamedSpace, which already take StringView. Take a StringView directly and
drop the intermediate local.
All three call sites pass an AtomString returned by
attributeWithoutSynchronization(), which converts to StringView just as it did
to const String&, so no string is allocated or copied either way. This just
lets the function accept a StringView caller without materializing a String.
* Source/WebCore/mathml/MathMLPresentationElement.cpp:
(WebCore::MathMLPresentationElement::parseMathMLLength):
* Source/WebCore/mathml/MathMLPresentationElement.h:
Canonical link: https://commits.webkit.org/318309@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
