Skip to site navigation (Press enter)
[webkit-changes] [WebKit/WebKit] 9a90b5: [Site Isolation] PDF HUD of cross-origin
</a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=webkit-changes@lists.webkit.org&q=from:%22Abrar+Rahman+Protyasha%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">Abrar Rahman Protyasha</span></span></a></span> <span class="date"><a href="/search?l=webkit-changes@lists.webkit.org&q=date:20260731" rel="nofollow">Fri, 31 Jul 2026 10:37:56 -0700</a></span> </p> </div> <div itemprop="articleBody" class="msgBody"> <!--X-Body-of-Message--> <pre> Branch: refs/heads/main Home: <a rel="nofollow" href="https://github.com/WebKit/WebKit">https://github.com/WebKit/WebKit</a> Commit: 9a90b5af0558a9b1bfa2f6500cfc1efcf51bd703 <a rel="nofollow" href="https://github.com/WebKit/WebKit/commit/9a90b5af0558a9b1bfa2f6500cfc1efcf51bd703">https://github.com/WebKit/WebKit/commit/9a90b5af0558a9b1bfa2f6500cfc1efcf51bd703</a> Author: Abrar Rahman Protyasha <a_protya...@apple.com> Date: 2026-07-31 (Fri, 31 Jul 2026)</pre><pre> Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/UnifiedPDFTests.mm Log Message: ----------- [Site Isolation] PDF HUD of cross-origin <iframe src=pdf> gets displaced by main frame scroll offset <a rel="nofollow" href="https://bugs.webkit.org/show_bug.cgi?id=320592">https://bugs.webkit.org/show_bug.cgi?id=320592</a> rdar://183356213 Reviewed by Richard Robinson. With site isolation enabled, if a remote parent's geometry changes (say, the frame scroll position), that does not actually modify the cross-origin <iframe> plugin's local root view transform. As such, we need to ask the plugin to re-report its HUD location to the UI process, which runs the main frame conversion with newer geometry. Otherwise, when the top-level page scrolls the HUD stays where it was first placed and drifts out of the iframe. We hook up this "ask the plugin" part by keying off frame tree sync data and calling WebPage::updatePDFHUDLocationsAfterRemoteFrameGeometryChange, which enumerates through the tracked PDF plugins and asks them to produce HUD location updates. Test: TestWebKitAPI.UnifiedPDF/EmbeddedPDFHUDSiteIsolation.HUDTracksMainFrameScroll * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::frameTreeSyncDataChangedInAnotherProcess): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::updatePDFHUDLocationsAfterRemoteFrameGeometryChange): * Tools/TestWebKitAPI/Tests/WebKit/WKWebView/UnifiedPDFTests.mm: (TestWebKitAPI::EmbeddedPDFHUDSiteIsolation::scrollableMainHTML const): (TestWebKitAPI::EmbeddedPDFHUDSiteIsolation::loadAndWaitForHUD): (TestWebKitAPI::TEST_P): We hoist the shared test setup into SetUp() (the gtest sanctioned test class initializer), which makes the main test logic easier to read. Canonical link: <a rel="nofollow" href="https://commits.webkit.org/318330@main">https://commits.webkit.org/318330@main</a> To unsubscribe from these emails, change your notification settings at <a rel="nofollow" href="https://github.com/WebKit/WebKit/settings/notifications">https://github.com/WebKit/WebKit/settings/notifications</a> </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg255086.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="index.html#255087">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="maillist.html#255087">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg255088.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="[webkit-changes] [WebKit/WebKit] 9a90b5: [Site Isolation] PDF HUD of cross-origin <iframe s..."> <input type="hidden" name="msgid" value="WebKit/WebKit/push/refs/heads/main/18b5fd-9a90b5@github.com"> <input type="hidden" name="relpath" value="webkit-changes@lists.webkit.org/msg255087.html"> <input type="submit" value=" Abrar Rahman Protyasha "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="webkit-changes@lists.webkit.org"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search webkit-changes"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/webkit-changes@lists.webkit.org/">webkit-changes - all messages</a></li> <li class="icons-about"><a href="/webkit-changes@lists.webkit.org/info.html">webkit-changes - about the list</a></li> <li class="icons-expand"><a href="/search?l=webkit-changes@lists.webkit.org&q=subject:%22%5C%5Bwebkit%5C-changes%5C%5D+%5C%5BWebKit%5C%2FWebKit%5C%5D+9a90b5%5C%3A+%5C%5BSite+Isolation%5C%5D+PDF+HUD+of+cross%5C-origin+%3Ciframe+s...%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg255086.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg255088.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">WebKit/WebKit/push/refs/heads/main/18b5fd-9a90b5@github.com</li> </ul> </div> </body> </html>