Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7be5445e4a22c61e7c197e81bbcb15d965650f7c
https://github.com/WebKit/WebKit/commit/7be5445e4a22c61e7c197e81bbcb15d965650f7c
Author: Devin Rousso <[email protected]>
Date: 2026-08-02 (Sun, 02 Aug 2026)
Changed paths:
M LayoutTests/inspector/canvas/resources/shaderProgram-utilities-webgpu.js
A LayoutTests/inspector/canvas/setShaderProgramDisabled-webgpu-expected.txt
A LayoutTests/inspector/canvas/setShaderProgramDisabled-webgpu.html
M LayoutTests/inspector/canvas/shaderProgram-add-remove-webgpu-expected.txt
M LayoutTests/inspector/canvas/shaderProgram-add-remove-webgpu.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/win/TestExpectations
M Source/JavaScriptCore/inspector/protocol/Canvas.json
M Source/WebCore/Modules/WebGPU/GPURenderBundleEncoder.cpp
M Source/WebCore/Modules/WebGPU/GPURenderBundleEncoder.h
M Source/WebCore/Modules/WebGPU/GPURenderPassEncoder.cpp
M Source/WebCore/Modules/WebGPU/GPURenderPassEncoder.h
M Source/WebCore/inspector/InspectorInstrumentation.cpp
M Source/WebCore/inspector/InspectorInstrumentation.h
M Source/WebCore/inspector/InspectorShaderProgram.cpp
M Source/WebCore/inspector/InspectorShaderProgram.h
M Source/WebCore/inspector/agents/InspectorCanvasAgent.cpp
M Source/WebCore/inspector/agents/InspectorCanvasAgent.h
M Source/WebInspectorUI/UserInterface/Models/ShaderProgram.js
M Source/WebInspectorUI/UserInterface/Views/ShaderProgramTreeElement.js
Log Message:
-----------
Web Inspector: Canvas: support disabling WebGPU render pipelines
https://bugs.webkit.org/show_bug.cgi?id=320700
Reviewed by Mike Wyrzykowski.
* Source/JavaScriptCore/inspector/protocol/Canvas.json:
* Source/WebCore/inspector/agents/InspectorCanvasAgent.h:
(WebCore::InspectorCanvasAgent::setShaderProgramDisabled):
(WebCore::InspectorCanvasAgent::isWebGPURenderPipelineDisabled): Added.
* Source/WebCore/inspector/agents/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::setShaderProgramDisabled):
(WebCore::InspectorCanvasAgent::isWebGPURenderPipelineDisabled): Added.
* Source/WebCore/inspector/InspectorShaderProgram.h:
* Source/WebCore/inspector/InspectorShaderProgram.cpp:
(WebCore::InspectorShaderProgram::setDisabled):
* Source/WebCore/inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::isWebGPURenderPipelineDisabled): Added.
(WebCore::InspectorInstrumentation::isWebGPURenderPipelineDisabledImpl): Added.
* Source/WebCore/inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::isWebGPURenderPipelineDisabledImpl): Added.
Expose disabling for `GPURenderPipeline` and throw when attempting the same for
`GPUComputePipeline`.
* Source/WebCore/Modules/WebGPU/GPURenderPassEncoder.h:
(WebCore::GPURenderPassEncoder):
* Source/WebCore/Modules/WebGPU/GPURenderPassEncoder.cpp:
(WebCore::GPURenderPassEncoder::setPipeline):
(WebCore::GPURenderPassEncoder::draw):
(WebCore::GPURenderPassEncoder::drawIndexed):
(WebCore::GPURenderPassEncoder::drawIndirect):
(WebCore::GPURenderPassEncoder::drawIndexedIndirect):
(WebCore::GPURenderPassEncoder::executeBundles):
(WebCore::GPURenderPassEncoder::end):
* Source/WebCore/Modules/WebGPU/GPURenderBundleEncoder.h:
(WebCore::GPURenderBundleEncoder):
* Source/WebCore/Modules/WebGPU/GPURenderBundleEncoder.cpp:
(WebCore::GPURenderBundleEncoder::setPipeline):
(WebCore::GPURenderBundleEncoder::draw):
(WebCore::GPURenderBundleEncoder::drawIndexed):
(WebCore::GPURenderBundleEncoder::drawIndirect):
(WebCore::GPURenderBundleEncoder::drawIndexedIndirect):
(WebCore::GPURenderBundleEncoder::finish):
Track the current `GPURenderPipeline` and bail if inspector says it's disabled.
* Source/WebInspectorUI/UserInterface/Models/ShaderProgram.js:
(WI.ShaderProgram.prototype.get supportsDisabling): Added.
(WI.ShaderProgram.prototype.set disabled):
* Source/WebInspectorUI/UserInterface/Views/ShaderProgramTreeElement.js:
(WI.ShaderProgramTreeElement.prototype.constructor):
(WI.ShaderProgramTreeElement.prototype.onattach):
(WI.ShaderProgramTreeElement.prototype.ondetach):
(WI.ShaderProgramTreeElement.prototype.populateContextMenu):
Also allow disabling for ` WI.Canvas.ContextType.WebGPU` (but not
`WI.ShaderProgram.ProgramType.Compute`).
* LayoutTests/inspector/canvas/resources/shaderProgram-utilities-webgpu.js:
* LayoutTests/inspector/canvas/setShaderProgramDisabled-webgpu.html: Added.
* LayoutTests/inspector/canvas/setShaderProgramDisabled-webgpu-expected.txt:
Added.
* LayoutTests/inspector/canvas/shaderProgram-add-remove-webgpu.html:
* LayoutTests/inspector/canvas/shaderProgram-add-remove-webgpu-expected.txt:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/win/TestExpectations:
Canonical link: https://commits.webkit.org/318403@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
