Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 68b163ff10b4fd22635480485907df5de9e6bc7a
https://github.com/WebKit/WebKit/commit/68b163ff10b4fd22635480485907df5de9e6bc7a
Author: Carlos Garcia Campos <[email protected]>
Date: 2026-08-03 (Mon, 03 Aug 2026)
Changed paths:
M
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayer.cpp
M
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayer.h
Log Message:
-----------
[GTK][WPE] Skia compositor:
CoordinatedPlatformLayer::hasCommittedContentsBuffer() uses m_skiaTarget and
can be called from different threads
https://bugs.webkit.org/show_bug.cgi?id=320890
Reviewed by Nikolas Zimmermann.
In CoordinatedPlatformLayer m_skiaTarget is not pretected by any lock
because it's only expected to be used from the compositing thread, but
it's used from hasCommittedContentsBuffer() that can be called from gst
threads. Add a bool flag protected by m_lock to note when the layer has
a committed contents buffer and use it instead of hasCommittedContentsBuffer().
*
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayer.cpp:
(WebCore::CoordinatedPlatformLayer::invalidateTarget):
(WebCore::CoordinatedPlatformLayer::setContentsBuffer):
(WebCore::CoordinatedPlatformLayer::replaceCurrentContentsBufferWithCopy):
(WebCore::CoordinatedPlatformLayer::flushCompositingStateOnTarget):
(WebCore::CoordinatedPlatformLayer::flushCompositingStateOnSkiaTarget):
(WebCore::CoordinatedPlatformLayer::hasCommittedContentsBuffer const): Deleted.
*
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayer.h:
Canonical link: https://commits.webkit.org/318445@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
