Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4b851b60b95111ab0376f92e4329bc6ae64c4e23
https://github.com/WebKit/WebKit/commit/4b851b60b95111ab0376f92e4329bc6ae64c4e23
Author: David Kilzer <[email protected]>
Date: 2026-08-03 (Mon, 03 Aug 2026)
Changed paths:
M Tools/Scripts/webkitpy/common/checkout/scm/git.py
M Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py
Log Message:
-----------
check-webkit-style --diff-files ignores the specified file paths and checks
the full branch diff
<https://bugs.webkit.org/show_bug.cgi?id=320950>
<rdar://183980017>
Reviewed by Zak Ridouh.
`Git.create_patch()` accepts a `changed_files` argument but never uses
it, so the paths passed to `check-webkit-style --diff-files` are simply
dropped and the entire branch diff is checked instead. A developer
narrowing a check to specific files then gets results for files they
did not name, with no warning.
Append `changed_files` as a trailing `--` pathspec, so that `git diff`
and `git format-patch`, the two command shapes `create_patch()` builds,
are limited to the requested files.
Tests:
webkitpy.common.checkout.scm.scm_unittest.GitTest.test_create_patch_with_changed_files
* Tools/Scripts/webkitpy/common/checkout/scm/git.py:
(Git.create_patch):
* Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(GitTest.test_create_patch_with_changed_files): Add.
Canonical link: https://commits.webkit.org/318519@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
