Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7bcf4016df4a19adc8e12a597c7e4be63626fb23
https://github.com/WebKit/WebKit/commit/7bcf4016df4a19adc8e12a597c7e4be63626fb23
Author: Devin Rousso <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M LayoutTests/inspector/canvas/console-record-2d-expected.txt
M LayoutTests/inspector/canvas/console-record-2d.html
M LayoutTests/inspector/canvas/resources/recording-2d.js
M LayoutTests/inspector/canvas/resources/recording-utilities.js
M Source/WebCore/inspector/agents/InspectorCanvasAgent.cpp
Log Message:
-----------
Web Inspector: Canvas: do not treat missing `console.record()` options as
present
https://bugs.webkit.org/show_bug.cgi?id=320949
Reviewed by Mike Wyrzykowski.
* Source/WebCore/inspector/agents/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::consoleStartRecordingCanvas):
`JSC::JSValue::operator bool` only checks whether a value is empty.
An option whose value is `undefined` was treated as present and converted to
`NaN`.
* LayoutTests/inspector/canvas/resources/recording-utilities.js:
* LayoutTests/inspector/canvas/resources/recording-2d.js:
* LayoutTests/inspector/canvas/console-record-2d.html:
* LayoutTests/inspector/canvas/console-record-2d-expected.txt:
Canonical link: https://commits.webkit.org/318555@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
