Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0c06c1222be25577be16cd332872ce568942f9db
https://github.com/WebKit/WebKit/commit/0c06c1222be25577be16cd332872ce568942f9db
Author: Sihui Liu <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M Source/WebCore/platform/graphics/GraphicsLayer.h
M Source/WebCore/platform/graphics/ca/FrameProcessIndicators.cpp
M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h
M Source/WebCore/rendering/RenderLayerBacking.cpp
Log Message:
-----------
Add a "pid=" label and stagger frame process indicators by nesting depth
https://bugs.webkit.org/show_bug.cgi?id=320471
rdar://183439648
Reviewed by Per Arne Vollan.
Follow-up to the frame process indicator overlay (bug 320012). Two changes to
make the
per-frame process ID overlay more usable when debugging site isolation:
- Prefix the label text with "pid=" so the number is unambiguous at a glance.
- Offset each indicator by its frame's nesting depth in the (cross-process)
frame tree, so
frames that share an origin on screen (e.g. a mainframe and an iframe both
anchored at the
page origin) don't draw their labels directly on top of each other. The
mainframe's label is
unstaggered; each level of nesting shifts the label further down and to the
right.
* Source/WebCore/platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::setShowFrameProcessBorders):
(WebCore::GraphicsLayer::frameProcessIndicatorDepth const):
* Source/WebCore/platform/graphics/ca/FrameProcessIndicators.cpp:
(WebCore::FrameProcessIndicators::FrameProcessIndicators):
(WebCore::FrameProcessIndicators::updateGeometry):
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDebugIndicators):
Canonical link: https://commits.webkit.org/318572@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
