Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a089757817eb946432770ba67dd61c51cc5ac17e
https://github.com/WebKit/WebKit/commit/a089757817eb946432770ba67dd61c51cc5ac17e
Author: Lauro Moura <[email protected]>
Date: 2026-08-05 (Wed, 05 Aug 2026)
Changed paths:
M Tools/CISupport/kill-old-processes
Log Message:
-----------
[Tools] kill-old-processes misses stuck run-webdriver-tests
https://bugs.webkit.org/show_bug.cgi?id=320988
Reviewed by Carlos Alberto Lopez Perez.
Recently, we had an issue where a stuck run-webdriver-tests from the
previous job was not caught by kill-old-processes, leaving its SDK
container up and affecting the subsequent runs on the same bot.
On top of that, the the current regex matching webkit commands like
run-webkit-tests expects a slash right before `python`, which is not the
case when the script uses a python executable from $PATH. As such, this
branch was in fact potentially not working at all on the bots for a
while.
Here's the list of Linux changes to avoid this in the future:
* Add run-webdriver-tests to the list of webkit commands to be killed,
alongside the existing run-webkit-tests.
* Instead of matching on a "*python" command from the raw ps output, use
its "comm" field, so the current bot behavior of using "python" from
$PATH matches the regex and void matching commands that happen to wrap
the actual target, like `bash -c ... | ...`.
* Also, if WEBKIT_CONTAINER_SDK_ENABLE_AUTOENTER is enabled, kill any
still running podman SDK container matching the label set by
linux_container_sdk_utils.py. As the bots run 1 worker per
pod/bare-metal machine, this would not affect other workers.
* Tools/CISupport/kill-old-processes:
(main):
Canonical link: https://commits.webkit.org/318629@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
