Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 51385a5dc8bf092dee60e0a7cdc96c9ebf1fa942
https://github.com/WebKit/WebKit/commit/51385a5dc8bf092dee60e0a7cdc96c9ebf1fa942
Author: Ahmad Saleem <[email protected]>
Date: 2026-08-05 (Wed, 05 Aug 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/picture-in-picture/request-picture-in-picture-consumes-user-activation-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/picture-in-picture/request-picture-in-picture-consumes-user-activation.html
M LayoutTests/platform/ios/TestExpectations
M
Source/WebCore/Modules/pictureinpicture/HTMLVideoElementPictureInPicture.cpp
Log Message:
-----------
requestPictureInPicture() does not consume the user activation
https://bugs.webkit.org/show_bug.cgi?id=320114
rdar://183621577
Reviewed by Jean-Yves Avenard.
requestPictureInPicture() is specified to consume the transient activation
right after
checking for it [1]. WebKit only did the check, so a page could enter both
Picture-in-Picture and fullscreen from a single click by requesting
Picture-in-Picture
first, since requestFullscreen() does consume it.
Consume it from a scope exit rather than where the specification does.
MediaElementSession::fullscreenPermitted(), reached through
webkitSetPresentationMode(),
is gated on Document::processingUserGestureForMedia(), which falls back to the
transient
activation when no user gesture token is on the stack — the usual case, since
the request
comes from an asynchronous continuation of a click. Consuming any earlier makes
HTMLVideoElement::setPresentationMode() return early, leaving the promise
unsettled. No
script can run in between, so the ordering is not observable.
Gating on userActivationRequired keeps a re-request for the element already in
Picture-in-Picture from consuming, as specified.
[1]
https://w3c.github.io/picture-in-picture/#dom-htmlvideoelement-requestpictureinpicture
Test:
imported/w3c/web-platform-tests/picture-in-picture/request-picture-in-picture-consumes-user-activation.html
*
LayoutTests/imported/w3c/web-platform-tests/picture-in-picture/request-picture-in-picture-consumes-user-activation-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/picture-in-picture/request-picture-in-picture-consumes-user-activation.html:
Added.
* LayoutTests/platform/ios/TestExpectations: Add Platform Specific Expectation
* Source/WebCore/Modules/pictureinpicture/HTMLVideoElementPictureInPicture.cpp:
(WebCore::HTMLVideoElementPictureInPicture::requestPictureInPicture):
Canonical link: https://commits.webkit.org/318673@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
