Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c0316c6d2b08826df91703f0970ee949f3883997
https://github.com/WebKit/WebKit/commit/c0316c6d2b08826df91703f0970ee949f3883997
Author: Ahmad Saleem <[email protected]>
Date: 2026-08-05 (Wed, 05 Aug 2026)
Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/rendering/RenderMultiColumnSet.cpp
Log Message:
-----------
Multicol column height ignores min-height when min-height exceeds max-height
https://bugs.webkit.org/show_bug.cgi?id=319553
rdar://182381903
Reviewed by Antti Koivisto.
RenderMultiColumnSet::calculateMaxColumnHeight() seeded the maximum column
height from the multicol block's available height and then re-clamped it by
max-height. But columnHeightAvailable() is already fully resolved via
computeLogicalHeight() -> constrainLogicalHeightByMinMax(), where min-height
wins over max-height. Re-applying max-height on top of that
resolved value
(without ever applying min-height) discarded a min-height that exceeds
max-height, so a block with e.g. height:20px; max-height:40px; min-height:100px
capped its columns at 40px instead of the resolved 100px, overflowing content.
When the available height is definite it is already correctly constrained, so
return it directly instead of re-clamping. The max-height clamp is only needed
in the auto-height case, where the seed is the infinite maxLogicalHeight().
* LayoutTests/TestExpectations: Unskip now passing test
* Source/WebCore/rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::calculateMaxColumnHeight const):
Canonical link:
https://flagged.apple.com:443/proxy?t2=Do3C9f6Bn3&o=aHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvMzE4Njc2QG1haW4=&emid=c2533c13-d1fe-4957-ae32-0f77b80aa787&c=11
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
