Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8577db2c85c6968809fd0e7375ec26ba32cf6279
https://github.com/WebKit/WebKit/commit/8577db2c85c6968809fd0e7375ec26ba32cf6279
Author: Chris Dumez <[email protected]>
Date: 2026-08-06 (Thu, 06 Aug 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-onerror.https.html
M Source/WebCore/Modules/webaudio/AudioWorkletNode.cpp
M Source/WebCore/Modules/webaudio/AudioWorkletNode.h
M Source/WebCore/Modules/webaudio/AudioWorkletProcessor.cpp
M Source/WebCore/Modules/webaudio/AudioWorkletProcessor.h
Log Message:
-----------
AudioWorkletNode processorerror event lacks filename, lineno and colno
https://bugs.webkit.org/show_bug.cgi?id=321057
Reviewed by Darin Adler.
When an exception was thrown from an AudioWorkletProcessor's process()
method, the ErrorEvent dispatched to onprocessorerror was always created
with an empty filename and 0 for lineno / colno, even though the actual
exception location was readily available. Chrome and Firefox populate
these fields from the thrown exception.
Capture the exception's location via the ExceptionDetails out-param that
reportException() already fills in, and thread it from the rendering
thread through to the dispatched ErrorEvent so that filename, lineno and
colno reflect the real error site.
No new tests, rebaselined WPT test to gain test coverage.
*
LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-onerror.https.html:
Rebaseline WPT test to gain test coverage. Without this fix, the last
subtest was failing in WebKit (but passing in Chrome / Firefox).
* Source/WebCore/Modules/webaudio/AudioWorkletNode.cpp:
(WebCore::AudioWorkletNode::process):
(WebCore::AudioWorkletNode::didFinishProcessingOnRenderingThread):
(WebCore::AudioWorkletNode::fireProcessorErrorOnMainThread):
* Source/WebCore/Modules/webaudio/AudioWorkletNode.h:
* Source/WebCore/Modules/webaudio/AudioWorkletProcessor.cpp:
(WebCore::AudioWorkletProcessor::process):
* Source/WebCore/Modules/webaudio/AudioWorkletProcessor.h:
Canonical link: https://commits.webkit.org/318705@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
