Branch: refs/heads/webkitglib/2.54
Home: https://github.com/WebKit/WebKit
Commit: e79203d1b6bbf1921b9a4d223386d375b598049f
https://github.com/WebKit/WebKit/commit/e79203d1b6bbf1921b9a4d223386d375b598049f
Author: Vitaly Dyachkov <[email protected]>
Date: 2026-08-06 (Thu, 06 Aug 2026)
Changed paths:
M LayoutTests/platform/glib/TestExpectations
A
LayoutTests/platform/glib/fast/text/mark-matches-overflow-clip-expected.txt
A
LayoutTests/platform/glib/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt
A
LayoutTests/platform/glib/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt
A
LayoutTests/platform/glib/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt
A
LayoutTests/platform/glib/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt
M LayoutTests/platform/gtk/TestExpectations
R LayoutTests/platform/gtk/fast/text/mark-matches-overflow-clip-expected.txt
R
LayoutTests/platform/gtk/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt
R
LayoutTests/platform/gtk/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt
R
LayoutTests/platform/gtk/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt
R
LayoutTests/platform/gtk/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt
M LayoutTests/platform/wpe/TestExpectations
M LayoutTests/platform/wpe/fast/forms/basic-textareas-expected.txt
M LayoutTests/platform/wpe/fast/overflow/scrollRevealButton-expected.txt
R LayoutTests/platform/wpe/fast/text/mark-matches-overflow-clip-expected.txt
R
LayoutTests/platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt
R
LayoutTests/platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt
R
LayoutTests/platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt
R
LayoutTests/platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt
M Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp
M Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp
Log Message:
-----------
Cherry-pick 317862@main (3e26dfad94fa).
https://bugs.webkit.org/show_bug.cgi?id=263810
[WPE][GTK][WKTR] Enable async overflow scrolling by default for WPTs
https://bugs.webkit.org/show_bug.cgi?id=263810
Reviewed by Carlos Garcia Campos.
Currently, async overflow scrolling in TestRunner is always enabled on
WPE and disabled on GTK. On macOS it is enabled only for WPT tests
starting from 270071@main. Doing the same on WPE and GTK makes the test
results more consistent with macOS and each other.
* Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::shouldEnableAsyncOverflowScrolling):
(WTR::TestController::platformSpecificFeatureDefaultsForTest const):
* Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp:
(WTR::shouldEnableAsyncOverflowScrolling):
(WTR::TestController::platformSpecificFeatureDefaultsForTest const):
* LayoutTests/platform/glib/TestExpectations:
*
LayoutTests/platform/glib/fast/text/mark-matches-overflow-clip-expected.txt:
Renamed from
LayoutTests/platform/gtk/fast/text/mark-matches-overflow-clip-expected.txt.
*
LayoutTests/platform/glib/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt:
Renamed from
LayoutTests/platform/gtk/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt.
*
LayoutTests/platform/glib/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt:
Renamed from
LayoutTests/platform/gtk/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt.
*
LayoutTests/platform/glib/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt:
Renamed from
LayoutTests/platform/gtk/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt.
*
LayoutTests/platform/glib/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt:
Renamed from
LayoutTests/platform/gtk/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt.
* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:
* LayoutTests/platform/wpe/fast/forms/basic-textareas-expected.txt:
* LayoutTests/platform/wpe/fast/overflow/scrollRevealButton-expected.txt:
*
LayoutTests/platform/wpe/fast/text/mark-matches-overflow-clip-expected.txt:
Removed.
*
LayoutTests/platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt:
Removed.
*
LayoutTests/platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt:
Removed.
*
LayoutTests/platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt:
Removed.
*
LayoutTests/platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt:
Removed.
Canonical link: https://commits.webkit.org/317862@main
Canonical link: https://commits.webkit.org/317695.63@webkitglib/2.54
Commit: b418bd6b65250410703eaaceb0e179112ec19e51
https://github.com/WebKit/WebKit/commit/b418bd6b65250410703eaaceb0e179112ec19e51
Author: Vitaly Dyachkov <[email protected]>
Date: 2026-08-06 (Thu, 06 Aug 2026)
Changed paths:
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/page/scrolling/coordinated/ScrollingTreeCoordinated.cpp
M
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayer.cpp
M
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayer.h
Log Message:
-----------
Cherry-pick 318342@main (10bb43f28006).
https://bugs.webkit.org/show_bug.cgi?id=320449
Unreviewed cherry-pick.
Improve `ScrollingTreeCoordinated` layer hit testing
https://bugs.webkit.org/show_bug.cgi?id=320449
Reviewed by Carlos Garcia Campos.
Current implementation walks the layer tree and returns the first layer
it encounters that has a scrolling node, with no check that this layer
is actually the one visually on top at the hit point. As a result, a
scrolling node can be chosen even when it's covered by an unrelated
element positioned on top of it.
This patch mirrors the `ScrollingTreeMac` implementation as closely as
possible: layers at the hit point are collected front-to-back, and a
candidate scrolling node is only accepted once `isScrolledBy()` confirms
it's actually an ancestor of the frontmost interactive layer with a
fallback to layers further back for the case where the frontmost layer
is itself non-interactive.
* Source/WebCore/page/scrolling/coordinated/ScrollingTreeCoordinated.cpp:
(WebCore::collectDescendantLayersAtPoint):
Walks the layer tree under a given point and builds a flat list of every
layer whose bounds contain the point.
(WebCore::isScrolledBy):
Given a candidate scrolling node and the actual frontmost hit layer,
walks up the frontmost layer's ancestor chain checking whether that
scrolling node owns it.
(WebCore::ScrollingTreeCoordinated::scrollingNodeForPoint):
Collects all candidate layers front-to-back, remembers the first
("frontmost") one that is interactive, and for each candidate checks
whether its scrolling node is confirmed by `isScrolledBy()` against that
frontmost layer. If the frontmost interactive layer itself isn't
scrollable, falls back to checking layers further behind it.
(WebCore::ScrollingTreeCoordinated::eventListenerRegionTypesForPoint const):
(WebCore::traverseDescendantLayersAtPoint): Deleted.
(WebCore::layersAtPointToCheckForScrolling):
(WebCore::layerEventRegionContainsPoint):
*
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayer.cpp:
(WebCore::CoordinatedPlatformLayer::setChildren):
(WebCore::CoordinatedPlatformLayer::removeFromParent):
(WebCore::CoordinatedPlatformLayer::masksToBounds const):
(WebCore::CoordinatedPlatformLayer::mask const):
(WebCore::CoordinatedPlatformLayer::parent const):
*
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayer.h:
(WebCore::CoordinatedPlatformLayer::parent const):
* LayoutTests/platform/glib/TestExpectations:
Canonical link: https://commits.webkit.org/318342@main
Canonical link: https://commits.webkit.org/317695.64@webkitglib/2.54
Compare: https://github.com/WebKit/WebKit/compare/580595538d7f...b418bd6b6525
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
