Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: acfe18ce0f1cb3f287d6f1730bd6179e8e7fa808
https://github.com/WebKit/WebKit/commit/acfe18ce0f1cb3f287d6f1730bd6179e8e7fa808
Author: Sam Weinig <[email protected]>
Date: 2026-08-06 (Thu, 06 Aug 2026)
Changed paths:
M LayoutTests/fast/css/line-height-get-computed-style-expected.txt
M LayoutTests/fast/css/line-height-get-computed-style.html
M Source/WebCore/css/values/primitives/CSSPrimitiveNumericRange.h
M Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h
M Source/WebCore/page/PrintContext.cpp
M Source/WebCore/rendering/TextAutoSizing.cpp
M Source/WebCore/rendering/style/AutosizeStatus.cpp
M Source/WebCore/style/StyleExtractorCustom.h
M Source/WebCore/style/values/inline/StyleLineHeight.cpp
M Source/WebCore/style/values/inline/StyleLineHeight.h
Log Message:
-----------
Model computed value line-height more closely to how its specified
https://bugs.webkit.org/show_bug.cgi?id=320995
Reviewed by Darin Adler.
Replaces awkward modeling of `line-height` computed value using LengthPercentage
with one that mirrors the spec. This removes the unused `calc` term and makes
things a bit more clear to the reader.
The removal of an unnecessary multiplication by 100 then later division by 100
that happened due to converting from storing as Percentage to storing as a
Number caused a small precision change in line-height-get-computed-style.html.
To avoid other precision changes issues, the evaluation functions have been
carefully constructed to retain the same set of conversions to LayoutUnit as
the older code.
* LayoutTests/fast/css/line-height-get-computed-style-expected.txt:
* LayoutTests/fast/css/line-height-get-computed-style.html:
* Source/WebCore/css/values/primitives/CSSPrimitiveNumericRange.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:
* Source/WebCore/page/PrintContext.cpp:
* Source/WebCore/rendering/TextAutoSizing.cpp:
* Source/WebCore/rendering/style/AutosizeStatus.cpp:
* Source/WebCore/style/StyleExtractorCustom.h:
* Source/WebCore/style/values/inline/StyleLineHeight.cpp:
* Source/WebCore/style/values/inline/StyleLineHeight.h:
Canonical link: https://commits.webkit.org/318710@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
