Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 50401aa703436ae5da9199772561a19b7d8c82dd
https://github.com/WebKit/WebKit/commit/50401aa703436ae5da9199772561a19b7d8c82dd
Author: Cole Carley <[email protected]>
Date: 2026-08-06 (Thu, 06 Aug 2026)
Changed paths:
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/animation/WebAnimationTime.cpp
M Source/WebCore/css/CSSPrimitiveValue.cpp
M Source/WebCore/css/CSSPrimitiveValue.h
M Source/WebCore/css/CSSPropertyInitialValues.cpp
M Source/WebCore/css/CSSUnits.cpp
M Source/WebCore/css/CSSUnits.h
M Source/WebCore/css/CSSValuePool.cpp
M Source/WebCore/css/ShorthandSerializer.cpp
M Source/WebCore/css/calc/CSSCalcTree+NumericIdentity.h
M Source/WebCore/css/calc/CSSCalcTree+Parser.cpp
M Source/WebCore/css/calc/CSSCalcTree+Serialization.cpp
M Source/WebCore/css/calc/CSSCalcTree+Simplification.cpp
M Source/WebCore/css/calc/CSSCalcTree.cpp
M Source/WebCore/css/calc/CSSCalcTree.h
M Source/WebCore/css/calc/CSSCalcType.cpp
M Source/WebCore/css/calc/CSSCalcValue.cpp
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValue.cpp
M Source/WebCore/css/parser/CSSParserFastPaths.cpp
M Source/WebCore/css/parser/CSSParserToken.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Background.cpp
M
Source/WebCore/css/parser/CSSPropertyParserConsumer+CSSPrimitiveValueResolver.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+LengthDefinitions.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Overflow.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Timeline.cpp
M Source/WebCore/css/parser/CSSPropertyParserCustom.h
M Source/WebCore/css/scripts/process-css-properties.py
M
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyInitialValuesGeneratedInlines.h
M Source/WebCore/css/typedom/CSSNumericFactory.h
M Source/WebCore/css/typedom/CSSNumericValue.cpp
M Source/WebCore/css/typedom/CSSStyleValueFactory.cpp
M Source/WebCore/css/typedom/CSSUnitValue.cpp
M Source/WebCore/css/typedom/color/CSSOMColorValue.cpp
M Source/WebCore/css/typedom/color/CSSRGB.cpp
M Source/WebCore/css/typedom/transform/CSSPerspective.cpp
M Source/WebCore/css/typedom/transform/CSSRotate.cpp
M Source/WebCore/css/typedom/transform/CSSScale.cpp
M Source/WebCore/css/typedom/transform/CSSSkew.cpp
M Source/WebCore/css/typedom/transform/CSSSkewX.cpp
M Source/WebCore/css/typedom/transform/CSSSkewY.cpp
M Source/WebCore/css/typedom/transform/CSSTranslate.cpp
M Source/WebCore/css/values/backgrounds/CSSBorderImageWidth.cpp
M Source/WebCore/css/values/color/CSSRelativeAlphaColorResolver.cpp
M Source/WebCore/css/values/color/CSSRelativeColorResolver.h
M Source/WebCore/css/values/primitives/CSSPrimitiveNumericUnits.h
M Source/WebCore/dom/ConstantPropertyMap.cpp
M Source/WebCore/dom/ImageOverlay.cpp
M Source/WebCore/dom/ViewTransition.cpp
M Source/WebCore/editing/ApplyStyleCommand.cpp
M Source/WebCore/editing/FontAttributeChanges.cpp
M Source/WebCore/editing/mac/EditorMac.mm
M Source/WebCore/html/FallbackPopupMenu.cpp
M Source/WebCore/html/HTMLAttachmentElement.cpp
M Source/WebCore/html/HTMLElement.cpp
M Source/WebCore/html/HTMLEmbedElement.cpp
M Source/WebCore/html/HTMLHRElement.cpp
M Source/WebCore/html/HTMLIFrameElement.cpp
M Source/WebCore/html/HTMLMarqueeElement.cpp
M Source/WebCore/html/HTMLMeterElement.cpp
M Source/WebCore/html/HTMLOptGroupElement.cpp
M Source/WebCore/html/HTMLProgressElement.cpp
M Source/WebCore/html/HTMLTableElement.cpp
M Source/WebCore/html/ImageDocument.cpp
M Source/WebCore/html/ValidationMessage.cpp
M Source/WebCore/html/shadow/DateTimeEditElement.cpp
M Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp
M Source/WebCore/html/shadow/SpatialImageControls.cpp
M Source/WebCore/html/shadow/TextPlaceholderElement.cpp
M Source/WebCore/html/track/VTTCue.cpp
M Source/WebCore/html/track/VTTRegion.cpp
M Source/WebCore/page/DragController.cpp
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/style/StyleExtractor.cpp
M Source/WebCore/style/StyleSubstitutionResolver.cpp
M
Source/WebCore/style/values/primitives/StyleLengthWrapper+DeprecatedCSSOMValueCreation.h
M
Source/WebCore/style/values/primitives/StylePrimitiveNumericOrKeyword+DeprecatedCSSValueConversion.h
M
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+CSSValueConversion.h
M
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Conversions.h
M
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+DeprecatedCSSValueConversion.h
M
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+DeprecatedConversions.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
Log Message:
-----------
Fix CSSUnitType enum member names
https://bugs.webkit.org/show_bug.cgi?id=321105
rdar://184144435
Reviewed by Kiet Ho.
Members of the CSSUnitType enum follow this pattern CSS_PX. This is
outdated and does not follow our style guide. This patch changes the
members to use PascalCase.
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::isTimelineRangeOffsetValid):
(WebCore::computeMissingKeyframeOffsets):
(WebCore::specifiedOffsetForParsedKeyframe):
* Source/WebCore/animation/WebAnimationTime.cpp:
(WebCore::WebAnimationTime::WebAnimationTime):
* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::~CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::create):
(WebCore::CSSPrimitiveValue::createInteger):
(WebCore::CSSPrimitiveValue::serializeInternal const):
(WebCore::CSSPrimitiveValue::customCSSText const):
(WebCore::CSSPrimitiveValue::equals const):
(WebCore::CSSPrimitiveValue::addDerivedHash const):
* Source/WebCore/css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isFontIndependentLength):
(WebCore::CSSPrimitiveValue::isParentFontRelativeLength):
(WebCore::CSSPrimitiveValue::isRootFontRelativeLength):
(WebCore::CSSPrimitiveValue::isContainerPercentageLength):
(WebCore::CSSPrimitiveValue::isLength):
* Source/WebCore/css/CSSPropertyInitialValues.cpp:
(WebCore::initialValueTextForLonghand):
* Source/WebCore/css/CSSUnits.cpp:
(WebCore::unitCategory):
(WebCore::canonicalUnitTypeForCategory):
(WebCore::operator<<):
(WebCore::conversionToCanonicalUnitsScaleFactor):
(WebCore::conversionToCanonicalUnitRequiresConversionData):
(WebCore::unitTypeString):
* Source/WebCore/css/CSSUnits.h:
* Source/WebCore/css/CSSValuePool.cpp:
(WebCore::StaticCSSValuePool::StaticCSSValuePool):
* Source/WebCore/css/ShorthandSerializer.cpp:
(WebCore::ShorthandSerializer::serializeFont const):
(WebCore::ShorthandSerializer::serializeSingleAnimationRange const):
* Source/WebCore/css/calc/CSSCalcTree+NumericIdentity.h:
(WebCore::CSSCalc::toNumericIdentity):
* Source/WebCore/css/calc/CSSCalcTree+Parser.cpp:
(WebCore::CSSCalc::consumeAnchorFallback):
(WebCore::CSSCalc::parseCalcDimension):
* Source/WebCore/css/calc/CSSCalcTree+Serialization.cpp:
(WebCore::CSSCalc::sortPriority):
* Source/WebCore/css/calc/CSSCalcTree+Simplification.cpp:
(WebCore::CSSCalc::canonicalize):
* Source/WebCore/css/calc/CSSCalcTree.cpp:
(WebCore::CSSCalc::makeNumeric):
* Source/WebCore/css/calc/CSSCalcTree.h:
(WebCore::CSSCalc::toCSSUnit):
* Source/WebCore/css/calc/CSSCalcType.cpp:
(WebCore::CSSCalc::Type::determineType):
* Source/WebCore/css/calc/CSSCalcValue.cpp:
(WebCore::CSSCalc::Value::primitiveType const):
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValue.cpp:
(WebCore::DeprecatedCSSOMPrimitiveValue::primitiveType const):
(WebCore::DeprecatedCSSOMPrimitiveValue::getFloatValue const):
* Source/WebCore/css/parser/CSSParserFastPaths.cpp:
(WebCore::parseSimpleLength):
(WebCore::parseSimpleLengthValue):
(WebCore::parseColorIntOrPercentage):
(WebCore::parseNumericColor):
(WebCore::parseTransformTranslateArguments):
(WebCore::parseTransformNumberArguments):
(WebCore::parseOpacity):
* Source/WebCore/css/parser/CSSParserToken.cpp:
(WebCore::cssPrimitiveValueUnitFromTrie):
(WebCore::CSSParserToken::CSSParserToken):
(WebCore::CSSParserToken::convertToPercentage):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Background.cpp:
(WebCore::CSSPropertyParserHelpers::consumeUnresolvedBorderImageWidth):
*
Source/WebCore/css/parser/CSSPropertyParserConsumer+CSSPrimitiveValueResolver.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp:
(WebCore::CSSPropertyParserHelpers::consumeRelativeFunctionParameters):
(WebCore::CSSPropertyParserHelpers::consumeRelativeAlphaColorFunction):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+LengthDefinitions.h:
(WebCore::CSSPropertyParserHelpers::LengthValidator::validate):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Overflow.cpp:
(WebCore::CSSPropertyParserHelpers::consumeOverflowClipMargin):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Timeline.cpp:
(WebCore::CSSPropertyParserHelpers::consumeSingleAnimationRange):
* Source/WebCore/css/parser/CSSPropertyParserCustom.h:
(WebCore::CSS::PropertyParserCustom::consumeFlexShorthand):
* Source/WebCore/css/scripts/process-css-properties.py:
(NumericLiteral.cpp_unit_type):
*
Source/WebCore/css/scripts/test/TestCSSPropertiesResults/CSSPropertyInitialValuesGeneratedInlines.h:
(WebCore::initialValueForLonghand):
* Source/WebCore/css/typedom/CSSNumericFactory.h:
* Source/WebCore/css/typedom/CSSNumericValue.cpp:
(WebCore::invert):
(WebCore::CSSNumericValue::multiplyInternal):
(WebCore::CSSNumericValue::reifyValue):
(WebCore::createCSSUnitValueFromAddend):
(WebCore::CSSNumericValue::toSum):
* Source/WebCore/css/typedom/CSSStyleValueFactory.cpp:
(WebCore::reifyValue):
* Source/WebCore/css/typedom/CSSUnitValue.cpp:
(WebCore::CSSUnitValue::parseUnit):
(WebCore::CSSUnitValue::unit const):
(WebCore::CSSUnitValue::create):
(WebCore::CSSUnitValue::reifyValue):
(WebCore::CSSUnitValue::toSumValue const):
(WebCore::isValueOutOfRangeForProperty):
(WebCore::calculationCategoryForProperty):
* Source/WebCore/css/typedom/color/CSSOMColorValue.cpp:
(WebCore::CSSOMColorValue::rectifyCSSColorPercent):
(WebCore::CSSOMColorValue::rectifyCSSColorAngle):
(WebCore::CSSOMColorValue::rectifyCSSColorNumber):
* Source/WebCore/css/typedom/color/CSSRGB.cpp:
(WebCore::CSSRGB::rectifyCSSColorRGBComp):
* Source/WebCore/css/typedom/transform/CSSPerspective.cpp:
(WebCore::CSSPerspective::toMatrix):
* Source/WebCore/css/typedom/transform/CSSRotate.cpp:
(WebCore::CSSRotate::create):
(WebCore::CSSRotate::toMatrix):
* Source/WebCore/css/typedom/transform/CSSScale.cpp:
(WebCore::CSSScale::create):
* Source/WebCore/css/typedom/transform/CSSSkew.cpp:
(WebCore::CSSSkew::toMatrix):
* Source/WebCore/css/typedom/transform/CSSSkewX.cpp:
(WebCore::CSSSkewX::toMatrix):
* Source/WebCore/css/typedom/transform/CSSSkewY.cpp:
(WebCore::CSSSkewY::toMatrix):
* Source/WebCore/css/typedom/transform/CSSTranslate.cpp:
(WebCore::CSSTranslate::create):
(WebCore::CSSTranslate::toMatrix):
* Source/WebCore/css/values/backgrounds/CSSBorderImageWidth.cpp:
(WebCore::CSS::BorderImageWidthValue::isLength const):
* Source/WebCore/css/values/color/CSSRelativeAlphaColorResolver.cpp:
(WebCore::CSS::resolve):
(WebCore::CSS::resolveNoConversionDataRequired):
* Source/WebCore/css/values/color/CSSRelativeColorResolver.h:
(WebCore::CSS::resolve):
(WebCore::CSS::resolveNoConversionDataRequired):
* Source/WebCore/css/values/primitives/CSSPrimitiveNumericUnits.h:
(WebCore::CSS::toCSSUnitType):
(WebCore::CSS::toIntegerUnit):
(WebCore::CSS::toNumberUnit):
(WebCore::CSS::toPercentageUnit):
(WebCore::CSS::toAngleUnit):
(WebCore::CSS::toLengthUnit):
(WebCore::CSS::toTimeUnit):
(WebCore::CSS::toFrequencyUnit):
(WebCore::CSS::toResolutionUnit):
(WebCore::CSS::toFlexUnit):
(WebCore::CSS::toAnglePercentageUnit):
(WebCore::CSS::toLengthPercentageUnit):
* Source/WebCore/dom/ConstantPropertyMap.cpp:
(WebCore::variableDataForPositivePixelLength):
(WebCore::variableDataForPositiveDuration):
* Source/WebCore/dom/ImageOverlay.cpp:
(WebCore::ImageOverlay::fitElementToQuad):
(WebCore::ImageOverlay::updateWithTextRecognitionResult):
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::copyElementBaseProperties):
* Source/WebCore/editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
* Source/WebCore/editing/FontAttributeChanges.cpp:
(WebCore::FontChanges::createStyleProperties const):
* Source/WebCore/editing/mac/EditorMac.mm:
(WebCore::Editor::platformPasteFont):
* Source/WebCore/html/FallbackPopupMenu.cpp:
(WebCore::applyFontCascade):
(WebCore::FallbackPopupMenu::buildPopupTree):
* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::insertionSteps):
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::applyBorderAttributeToStyle):
(WebCore::HTMLElement::addHTMLLengthToStyle):
(WebCore::HTMLElement::addHTMLPixelLengthToStyle):
* Source/WebCore/html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::collectPresentationalHintsForAttribute):
* Source/WebCore/html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::collectPresentationalHintsForAttribute):
* Source/WebCore/html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::collectPresentationalHintsForAttribute):
* Source/WebCore/html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::collectPresentationalHintsForAttribute):
* Source/WebCore/html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::didChangeElementValue):
* Source/WebCore/html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::didAddUserAgentShadowRoot):
* Source/WebCore/html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::didChangeElementValue):
* Source/WebCore/html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::collectPresentationalHintsForAttribute):
(WebCore::HTMLTableElement::createSharedCellStyle const):
* Source/WebCore/html/ImageDocument.cpp:
(WebCore::ImageDocument::createDocumentStructure):
* Source/WebCore/html/ValidationMessage.cpp:
(WebCore::ValidationMessage::adjustBubblePosition):
* Source/WebCore/html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitLiteral):
* Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateTextStrokeStyle):
(WebCore::MediaControlTextTrackContainerElement::updateTextTrackStyle):
* Source/WebCore/html/shadow/SpatialImageControls.cpp:
(WebCore::SpatialImageControls::ensureSpatialControls):
* Source/WebCore/html/shadow/TextPlaceholderElement.cpp:
(WebCore::TextPlaceholderElement::TextPlaceholderElement):
* Source/WebCore/html/track/VTTCue.cpp:
(WebCore::VTTCueBox::applyCSSPropertiesWithRegion):
(WebCore::VTTCueBox::applyCSSProperties):
* Source/WebCore/html/track/VTTRegion.cpp:
(WebCore::VTTRegion::displayLastTextTrackCueBox):
(WebCore::VTTRegion::willRemoveTextTrackCueBox):
(WebCore::VTTRegion::prepareRegionDisplayTree):
* Source/WebCore/page/DragController.cpp:
(WebCore::DragController::startDrag):
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
* Source/WebCore/style/StyleExtractor.cpp:
(WebCore::Style::Extractor::getFontSizeCSSValuePreferringKeyword const):
* Source/WebCore/style/StyleSubstitutionResolver.cpp:
(WebCore::Style::SubstitutionResolver::substituteAttrFunction):
*
Source/WebCore/style/values/primitives/StyleLengthWrapper+DeprecatedCSSOMValueCreation.h:
(WebCore::Style::deprecatedConvertLengthWrapperFromCSSValue):
*
Source/WebCore/style/values/primitives/StylePrimitiveNumericOrKeyword+DeprecatedCSSValueConversion.h:
(WebCore::Style::deprecatedConvertPrimitiveNumericOrKeywordFromCSSValue):
*
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+CSSValueConversion.h:
(WebCore::Style::convertNumericFromCSSValue):
*
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Conversions.h:
*
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+DeprecatedCSSValueConversion.h:
(WebCore::Style::deprecatedConvertNumericFromCSSValue):
*
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+DeprecatedConversions.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
(WebKit::PDFPluginAnnotation::updateGeometry):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:
(WebKit::PDFPluginChoiceAnnotation::updateGeometry):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::updateGeometry):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::sizeToFitContentsIfNeeded):
Canonical link: https://commits.webkit.org/318727@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
