Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ebe9a17c92fb3e6430085cf3ce6b6fa5b5d8d508
https://github.com/WebKit/WebKit/commit/ebe9a17c92fb3e6430085cf3ce6b6fa5b5d8d508
Author: Richard Robinson <[email protected]>
Date: 2026-08-06 (Thu, 06 Aug 2026)
Changed paths:
M Source/WebKit/UIProcess/PDF/WKAlternatePDFHUDView+Testing.swift
M Source/WebKit/UIProcess/PDF/WKAlternatePDFHUDView.swift
M Source/WebKit/UIProcess/mac/WKAppKitGestureController.mm
M Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift
Log Message:
-----------
[AppKit Gestures] Clicking on PDF does not show HUD when using the alternate
PDF HUD
https://bugs.webkit.org/show_bug.cgi?id=321196
rdar://184256037
Reviewed by Wenson Hsieh and Abrar Rahman Protyasha.
Implement `show` for the alternate PDF HUD view.
Test: Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift
* Source/WebKit/UIProcess/PDF/WKAlternatePDFHUDView+Testing.swift:
(WKAlternatePDFHUDView.hideForTesting):
* Source/WebKit/UIProcess/PDF/WKAlternatePDFHUDView.swift:
(PDFHUDControlsModel.resetSeed):
(PDFHUDControlsModel.isVisible):
(PDFHUDControlsModel.show):
(PDFHUDControls.body):
(WKAlternatePDFHUDView.show):
(PDFHUDControls.isVisible): Deleted.
Extract the state into an observable model so that the state can be affected by
the outside.
* Source/WebKit/UIProcess/mac/WKAppKitGestureController.mm:
(-[WKAppKitGestureController singleClickGestureRecognized:]):
Skip this workaround when using the alternate PDF HUD; it wouldn't do anything
anyways, and it
seems to work fine as-is.
* Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift:
Canonical link: https://commits.webkit.org/318740@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
