Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 906e60b3d82986684b7907e52b909c4a1e6982d8
https://github.com/WebKit/WebKit/commit/906e60b3d82986684b7907e52b909c4a1e6982d8
Author: Lauro Moura <[email protected]>
Date: 2026-08-06 (Thu, 06 Aug 2026)
Changed paths:
M Tools/Scripts/webkitpy/webdriver_tests/pytest_runner.py
Log Message:
-----------
[WebDriver][Tools] Fix pytest_collection_modifyitems to support proper flaky
expectations
https://bugs.webkit.org/show_bug.cgi?id=321175
Reviewed by Carlos Alberto Lopez Perez.
Ensure we check the whole expectation list when installing the pytest
markers. Previously, only the first item was checked, effectively
ignoring flaky expectations, which have multiple expected outcomes.
As pytest has no natural flaky test marker, flakies are marked as xfail,
which, in the case of a pass, currently are reported as XPASS. To avoid
polluting the final report and hiding true XPASS cases, we also report
the flaky passes as regular PASS in the outer harness and resulting
json. The same approach is used for FAIL/TIMEOUT, to avoid the empty
xfail to mark an expected flaky timeout as a true timeout.
* Tools/Scripts/webkitpy/webdriver_tests/pytest_runner.py:
(SubtestResultRecorder.record_pass):
(TestExpectationsMarker.pytest_collection_modifyitems):
Canonical link: https://commits.webkit.org/318761@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
