Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 95ffc89f5eb494d6b3918b7f6e98cc85bad52892
https://github.com/WebKit/WebKit/commit/95ffc89f5eb494d6b3918b7f6e98cc85bad52892
Author: Sosuke Suzuki <[email protected]>
Date: 2026-08-06 (Thu, 06 Aug 2026)
Changed paths:
M Source/JavaScriptCore/assembler/JITOperationValidation.h
Log Message:
-----------
[JSC] `JSC_JIT_CAGE_PROBE{,_IMPL}` fallback macros in
`JITOperationValidation.h` do not compile
https://bugs.webkit.org/show_bug.cgi?id=321214
Reviewed by Keith Miller.
318675@main added no-op fallbacks for JSC_JIT_CAGE_PROBE and
JSC_JIT_CAGE_PROBE_IMPL for when <WebKitAdditions/JITCageAdditions.h> does not
provide them, but both had copy-paste mistakes:
1. Both bodies were `(void)x` while the parameter is `v`, so any expansion
(LLIntData.cpp) fails with an undeclared identifier.
2. The `#ifndef JSC_JIT_CAGE_PROBE_IMPL` block defined JSC_JIT_CAGE_PROBE
again instead of JSC_JIT_CAGE_PROBE_IMPL, leaving the latter with no
fallback (LLIntThunks.cpp) and redefining the former if the SDK header
only provides JSC_JIT_CAGE_PROBE.
Use `(void)(v)` in both and define JSC_JIT_CAGE_PROBE_IMPL in the second block.
No behavior change for open-source builds since ENABLE(JIT_CAGE) is off there.
* Source/JavaScriptCore/assembler/JITOperationValidation.h:
Canonical link: https://commits.webkit.org/318765@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
