Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: aa6c61fcb0020c75099f15ccbfaa14380fb55c89
https://github.com/WebKit/WebKit/commit/aa6c61fcb0020c75099f15ccbfaa14380fb55c89
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-08-07 (Fri, 07 Aug 2026)
Changed paths:
M Source/cmake/WebKitCommon.cmake
M Tools/Scripts/make-dist
Log Message:
-----------
[GTK][WPE][CMake] Do not allow to build with make, require ninja instead.
https://bugs.webkit.org/show_bug.cgi?id=321266
Reviewed by Carlos Garcia Campos.
Currently for building GTK or WPE there are two ways: use the build-webkit
script
or use CMake directly. The build-webkit script is only intended for webkit
developers, for production releases or users of webkit the idea is to use cmake
directly.
The problem is that we have a split on how WebKit is built. With build-webkit
ninja is used by default, but when using cmake directly it uses whatever cmake
generator has as default (make usually) and that is causing issues because of
build errors due to dependencies between targets, ninja has its own dependency
graph, but plain makefiles don't.
And this causes issues when someone tries to use make because no one usually
tests the make build.
This patch makes ninja mandatory for GTK and WPE ports and also changes the
make-dist script to use it.
* Source/cmake/WebKitCommon.cmake:
* Tools/Scripts/make-dist:
(Distcheck.configure):
(Distcheck.build):
(Distcheck.install):
Canonical link: https://commits.webkit.org/318773@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
