Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dfc0426a5fa1908fbca70f290e6ea2d9cdff7c14
https://github.com/WebKit/WebKit/commit/dfc0426a5fa1908fbca70f290e6ea2d9cdff7c14
Author: Lily Spiniolas <[email protected]>
Date: 2026-08-08 (Sat, 08 Aug 2026)
Changed paths:
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Scripts/webkit/messages.py
A Source/WebKit/Shared/PDFAccessibilityDisplayModeState.h
A Source/WebKit/Shared/PDFAccessibilityDisplayModeState.serialization.in
M Source/WebKit/UIProcess/PDF/WKAlternatePDFHUDView.swift
M Source/WebKit/UIProcess/PDF/WKDefaultPDFHUDView.swift
M Source/WebKit/UIProcess/PDF/WKPDFHUDView.h
M Source/WebKit/UIProcess/PageClient.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/UIProcess/mac/PageClientImplMac.h
M Source/WebKit/UIProcess/mac/PageClientImplMac.mm
M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm
M
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.h
M
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.mm
M
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.h
M
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.mm
M
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.h
M
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm
Log Message:
-----------
[Unified PDF] PDF HUD should show toggle for accessibility filters
https://bugs.webkit.org/show_bug.cgi?id=320864
rdar://183607542
Reviewed by Abrar Rahman Protyasha.
If a PDF is loaded with PDF accessibility filters enabled, add an item
to the PDF HUD to toggle the filter on and off. If no accessibility filter
is enabled/present, no toggle is added.
When the toggle is activated (or if the filter itself is disabled for PDFs
as a whole) the PDF is now completely redrawn using the new rendering settings
in order to reflect the correct state.
* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Scripts/webkit/messages.py:
(headers_for_type):
* Source/WebKit/Shared/PDFAccessibilityDisplayModeState.h: Copied from
Source/WebKit/UIProcess/PDF/WKPDFHUDView.h.
* Source/WebKit/Shared/PDFAccessibilityDisplayModeState.serialization.in: Added.
* Source/WebKit/UIProcess/PDF/WKAlternatePDFHUDView.swift:
(ControlsModel.isVisible):
(ControlsModel.accessibilityDisplayModeState):
(Controls.body):
(WKAlternatePDFHUDView.setAccessibilityDisplayModeState(_:)):
(Controls.isVisible): Deleted.
* Source/WebKit/UIProcess/PDF/WKDefaultPDFHUDView.swift:
(WKDefaultPDFHUDView.accessibilityDisplayModeButton):
(WKDefaultPDFHUDView.setAccessibilityDisplayModeState(_:)):
(WKDefaultPDFHUDView._performAction(forControl:)):
(WKDefaultPDFHUDView.hitTest(_:)):
(WKDefaultPDFHUDView.toggleAccessibilityDisplayModeAction):
* Source/WebKit/UIProcess/PDF/WKPDFHUDView.h:
* Source/WebKit/UIProcess/PageClient.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/mac/PageClientImplMac.h:
* Source/WebKit/UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::updatePDFHUDAccessibilityDisplayMode):
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::updatePDFHUDAccessibilityDisplayMode):
(WebKit::WebPageProxy::pdfToggleAccessibilityDisplayMode):
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::platformAccessibilityDisplayModeState):
(WebKit::WebViewImpl::createPDFHUD):
(WebKit::WebViewImpl::updatePDFHUDLocation):
(WebKit::WebViewImpl::updatePDFHUDAccessibilityDisplayMode):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
(WebKit::PDFPluginBase::toggleAccessibilityDisplayMode):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::accessibilityDisplayModeState const):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm:
(WebKit::AsyncPDFRenderer::invalidateAllRenderedContent):
*
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.h:
*
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.mm:
(WebKit::PDFDiscretePresentationController::updateLayersForAccessibilityDisplayModeChange):
(WebKit::PDFDiscretePresentationController::updateForAccessibilityDisplayModeChange):
Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.mm:
(WebKit::PDFPresentationController::updateForAccessibilityDisplayModeChange):
(WebKit::PDFPresentationController::invalidateRenderedContentForAccessibilityDisplayModeChange):
Deleted.
*
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.h:
*
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.mm:
(WebKit::PDFScrollingPresentationController::updateLayersForAccessibilityDisplayModeChange):
(WebKit::PDFScrollingPresentationController::updateForAccessibilityDisplayModeChange):
Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::defaultAccessibilityDisplayModeStateForCurrentSettings
const):
(WebKit::pdfPluginBackgroundColor):
(WebKit::UnifiedPDFPlugin::UnifiedPDFPlugin):
(WebKit::UnifiedPDFPlugin::didChangeSettings):
(WebKit::UnifiedPDFPlugin::setAccessibilityDisplayModeState):
(WebKit::UnifiedPDFPlugin::pluginBackgroundColor const):
(WebKit::UnifiedPDFPlugin::updateHUDAccessibilityDisplayMode):
(WebKit::UnifiedPDFPlugin::toggleAccessibilityDisplayMode):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::togglePDFAccessibilityDisplayMode):
(WebKit::WebPage::createPDFHUD):
(WebKit::WebPage::updatePDFHUDAccessibilityDisplayMode):
Canonical link: https://commits.webkit.org/318845@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
