Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8cbbfc9b154d2063cf96f04b40ae7e437fac9241
https://github.com/WebKit/WebKit/commit/8cbbfc9b154d2063cf96f04b40ae7e437fac9241
Author: Ahmad Saleem <[email protected]>
Date: 2026-08-09 (Sun, 09 Aug 2026)
Changed paths:
M LayoutTests/fast/css/webkit-line-clamp-calculated-value-expected.txt
M LayoutTests/fast/css/webkit-line-clamp-calculated-value.html
M LayoutTests/fast/overflow/line-clamp.html
M LayoutTests/platform/glib/fast/overflow/line-clamp-expected.txt
M LayoutTests/platform/ios/fast/overflow/line-clamp-expected.txt
M LayoutTests/platform/mac/fast/overflow/line-clamp-expected.txt
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
R Source/WebCore/style/values/non-standard/StyleWebKitLineClamp.cpp
M Source/WebCore/style/values/non-standard/StyleWebKitLineClamp.h
Log Message:
-----------
Remove non-standard `percentage` value from `-webkit-line-clamp`
https://bugs.webkit.org/show_bug.cgi?id=298000
rdar://159808285
Reviewed by Alan Baradlay.
This patch removes non-standard percentage value from `-webkit-line-clamp`,
which is not present in new standard for `line-clamp` plus this was also
dropped from Blink in 2018 [1] due to lack of usage and it also has quirky
undefined behavior different from web developer expectations in percentage
distribution between lines.
[1]
https://chromium.googlesource.com/chromium/src.git/+/7dc2379d58e26905dd77c56617d0baf9972581eb
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::hasClampingAndNoFlexing const):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::lineCountFor): Deleted.
* Source/WebCore/style/values/non-standard/StyleWebKitLineClamp.cpp: Removed.
* Source/WebCore/style/values/non-standard/StyleWebKitLineClamp.h:
(WebCore::Style::WebkitLineClamp::WebkitLineClamp): Deleted.
(WebCore::Style::WebkitLineClamp::isNone const): Deleted.
(WebCore::Style::WebkitLineClamp::isPercentage const): Deleted.
(WebCore::Style::WebkitLineClamp::isInteger const): Deleted.
(WebCore::Style::WebkitLineClamp::tryPercentage const): Deleted.
(WebCore::Style::WebkitLineClamp::tryInteger const): Deleted.
(WebCore::Style::WebkitLineClamp::holdsAlternative const): Deleted.
(WebCore::Style::WebkitLineClamp::switchOn const): Deleted.
(WebCore::Style::WebkitLineClamp::valueForTextAutosizingHash const): Deleted.
> Tests:
* LayoutTests/fast/css/webkit-line-clamp-calculated-value-expected.txt:
* LayoutTests/fast/css/webkit-line-clamp-calculated-value.html:
* LayoutTests/fast/overflow/line-clamp.html:
* LayoutTests/platform/mac/fast/overflow/line-clamp-expected.txt:
* LayoutTests/platform/ios/fast/overflow/line-clamp-expected.txt:
* LayoutTests/platform/glib/fast/overflow/line-clamp-expected.txt:
Canonical link: https://commits.webkit.org/318858@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
