Title: [115531] trunk
- Revision
- 115531
- Author
- [email protected]
- Date
- 2012-04-27 20:20:53 -0700 (Fri, 27 Apr 2012)
Log Message
Remove SHADER_COMPILER constant
https://bugs.webkit.org/show_bug.cgi?id=85115
Reviewed by Darin Adler.
Source/WebCore:
Removed constant which was previously removed from spec. Updated
layout test and expected results.
* html/canvas/WebGLRenderingContext.idl:
LayoutTests:
* fast/canvas/webgl/constants-expected.txt: Updated expected results.
* fast/canvas/webgl/constants.html: Synced test with Khronos repository.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (115530 => 115531)
--- trunk/LayoutTests/ChangeLog 2012-04-28 03:12:25 UTC (rev 115530)
+++ trunk/LayoutTests/ChangeLog 2012-04-28 03:20:53 UTC (rev 115531)
@@ -1,3 +1,13 @@
+2012-04-27 Kenneth Russell <[email protected]>
+
+ Remove SHADER_COMPILER constant
+ https://bugs.webkit.org/show_bug.cgi?id=85115
+
+ Reviewed by Darin Adler.
+
+ * fast/canvas/webgl/constants-expected.txt: Updated expected results.
+ * fast/canvas/webgl/constants.html: Synced test with Khronos repository.
+
2012-04-27 Joe Thomas <[email protected]>
fast/forms/listbox-clear-restore.html is failing
Modified: trunk/LayoutTests/fast/canvas/webgl/constants-expected.txt (115530 => 115531)
--- trunk/LayoutTests/fast/canvas/webgl/constants-expected.txt 2012-04-28 03:12:25 UTC (rev 115530)
+++ trunk/LayoutTests/fast/canvas/webgl/constants-expected.txt 2012-04-28 03:20:53 UTC (rev 115531)
@@ -5,6 +5,7 @@
Canvas.getContext
PASS All WebGL constants found to have correct values.
+PASS All constants removed from WebGL spec were absent from WebGL context.
PASS successfullyParsed is true
Modified: trunk/LayoutTests/fast/canvas/webgl/constants.html (115530 => 115531)
--- trunk/LayoutTests/fast/canvas/webgl/constants.html 2012-04-28 03:12:25 UTC (rev 115530)
+++ trunk/LayoutTests/fast/canvas/webgl/constants.html 2012-04-28 03:20:53 UTC (rev 115531)
@@ -372,7 +372,6 @@
/* Shader Source */
COMPILE_STATUS : 0x8B81,
-SHADER_COMPILER : 0x8DFA,
/* Shader Precision-Specified Types */
LOW_FLOAT : 0x8DF0,
@@ -436,10 +435,33 @@
BROWSER_DEFAULT_WEBGL : 0x9244
};
+// Constants removed from the WebGL spec compared to ES 2.0
+var removedConstants = {
+NUM_COMPRESSED_TEXTURE_FORMATS : 0x86A2,
+FIXED : 0x140C,
+ACTIVE_UNIFORM_MAX_LENGTH : 0x8B87,
+ACTIVE_ATTRIBUTE_MAX_LENGTH : 0x8B8A,
+EXTENSIONS : 0x1F03,
+INFO_LOG_LENGTH : 0x8B84,
+SHADER_SOURCE_LENGTH : 0x8B88,
+SHADER_COMPILER : 0x8DFA,
+SHADER_BINARY_FORMATS : 0x8DF8,
+NUM_SHADER_BINARY_FORMATS : 0x8DF9,
+};
+
function assertProperty(v, p) {
- if (v[p] == null) {
+ if (p in v) {
+ return true;
+ } else {
testFailed("Property does not exist: " + p)
return false;
+ }
+}
+
+function assertNoProperty(v, p) {
+ if (p in v) {
+ testFailed("Property is defined and should not be: " + p)
+ return false;
} else {
return true;
}
@@ -464,6 +486,14 @@
if (passed) {
testPassed("All WebGL constants found to have correct values.");
}
+passed = true;
+for (var i in removedConstants) {
+ var r = assertNoProperty(gl, i);
+ passed = passed && r;
+}
+if (passed) {
+ testPassed("All constants removed from WebGL spec were absent from WebGL context.");
+}
var extended = false;
for (var i in gl) {
if (i.match(/^[^a-z]/) && constants[i] == null) {
@@ -478,8 +508,6 @@
debug("");
</script>
<script src=""
-<script>
-</script>
</body>
</html>
Modified: trunk/Source/WebCore/ChangeLog (115530 => 115531)
--- trunk/Source/WebCore/ChangeLog 2012-04-28 03:12:25 UTC (rev 115530)
+++ trunk/Source/WebCore/ChangeLog 2012-04-28 03:20:53 UTC (rev 115531)
@@ -1,3 +1,15 @@
+2012-04-27 Kenneth Russell <[email protected]>
+
+ Remove SHADER_COMPILER constant
+ https://bugs.webkit.org/show_bug.cgi?id=85115
+
+ Reviewed by Darin Adler.
+
+ Removed constant which was previously removed from spec. Updated
+ layout test and expected results.
+
+ * html/canvas/WebGLRenderingContext.idl:
+
2012-04-27 Arvid Nilsson <[email protected]>
[BlackBerry] Fixed background is scrolling in http://www.nieuwecode.nl
Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContext.idl (115530 => 115531)
--- trunk/Source/WebCore/html/canvas/WebGLRenderingContext.idl 2012-04-28 03:12:25 UTC (rev 115530)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContext.idl 2012-04-28 03:20:53 UTC (rev 115531)
@@ -384,7 +384,6 @@
/* Shader Source */
const unsigned int COMPILE_STATUS = 0x8B81;
- const unsigned int SHADER_COMPILER = 0x8DFA;
/* Shader Precision-Specified Types */
const unsigned int LOW_FLOAT = 0x8DF0;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
