Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ba2e302bc68dcc8eafe723690196277afc1948ae
https://github.com/WebKit/WebKit/commit/ba2e302bc68dcc8eafe723690196277afc1948ae
Author: Issac Roy <[email protected]>
Date: 2026-08-10 (Mon, 10 Aug 2026)
Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
REGRESSION(318091@main): No possible to merge cherry-pick PRs in stable
branches
https://bugs.webkit.org/show_bug.cgi?id=321079
rdar://184249857
Reviewed by Ryan Haddad and Aakash Jain.
318091@main anchored the reviewer greps to the start of a line, which made
them reject indented reviewer lines. `git-webkit cherry-pick` indents the
original commit message by four spaces, so cherry-pick PRs always failed with
"No reviewer information in commit message". A hand-typed leading space breaks
it the same way.
Allow leading whitespace. Mid-line matches, which 318091@main fixed, are still
rejected. Use [[:space:]] rather than \s, since \s is a GNU extension and not
POSIX BRE.
* Tools/CISupport/ews-build/steps.py:
(ValidateCommitMessage.run):
* Tools/CISupport/ews-build/steps_unittest.py:
(TestValidateCommitMessage.test_success_indented_cherry_pick): Added.
Canonical link: https://commits.webkit.org/318916@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
