Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 01e439d2c3498c1cf84d6f62ba07d7c847c3670b
https://github.com/WebKit/WebKit/commit/01e439d2c3498c1cf84d6f62ba07d7c847c3670b
Author: Lauro Moura <[email protected]>
Date: 2026-08-10 (Mon, 10 Aug 2026)
Changed paths:
M Tools/Scripts/webkitpy/webdriver_tests/pytest_runner.py
M Tools/Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py
Log Message:
-----------
[WebDriver][Tools] Ensure selenium tests print the driver and browser output
https://bugs.webkit.org/show_bug.cgi?id=321320
Reviewed by Carlos Alberto Lopez Perez.
Imported Selenium tests conftest.py does not provide a verbose option,
effectively hiding the browser and driver output. This makes it harder
to identify issues that would be otherwise reported by this hidden
output. While the service class provides the `log_output` parameter, its
creation for the tests is handled within the imported code, in
comparison to other scripts like run-mvt-tests.
This commit adds a pytest plugin that, when --verbose is active,
monkeypatches Selenium's Service class (the one that wraps the driver),
ensuring the underlying driver inherits the descriptors from the harness
if it would be redirected to /dev/null by the original constructor. It
also defers importing selenium to the pytest_configure hook, when pytest
already configured the path to the vendored selenium used in the
imported tests.
* Tools/Scripts/webkitpy/webdriver_tests/pytest_runner.py:
(run):
* Tools/Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
(_BrowserOutputPlugin):
(_BrowserOutputPlugin.pytest_configure):
(_BrowserOutputPlugin.pytest_configure.init_inheriting_stdio):
(WebDriverSeleniumExecutor.__init__):
(WebDriverSeleniumExecutor.run):
Canonical link: https://commits.webkit.org/318925@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
