Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c9066d908eb5a9ccd0198e1360b62dd88857a393
https://github.com/WebKit/WebKit/commit/c9066d908eb5a9ccd0198e1360b62dd88857a393
Author: Roberto Rodriguez <[email protected]>
Date: 2026-08-11 (Tue, 11 Aug 2026)
Changed paths:
M Tools/Scripts/update-angle
Log Message:
-----------
[ANGLE] Update the update-angle script
https://bugs.webkit.org/show_bug.cgi?id=321327
rdar://184363140
Reviewed by Kimmo Kinnunen.
Four fixes found while updating ANGLE:
1. The temp work repository has no local config, so it can inherit a global
commit.gpgsign. Its synthetic identity has no signing key, so the merge
commit fails. Set commit.gpgsign=false there.
2. run_code_generation.py calls depot_tools' `git cl format --full`, which
aborts unless it can name a commit to diff against. It normally takes one
from the current branch's upstream, but the merge worktree is detached.
git cl reads rietveld.upstream-branch when there is no branch, so set
that to HEAD in the work repo's config.
3. Code generation failure was a warning, so incomplete output reached finalize
alongside hash files describing content that no longer existed. Make it
fatal.
4. Warn when CMakeLists.txt or *.cmake still name a source deleted upstream,
which breaks the CMake ports.
* Tools/Scripts/update-angle:
(phase_prepare):
(phase_codegen_a):
(_check_cmake_source_refs):
(phase_bookkeep):
(phase_codegen_b):
Canonical link: https://commits.webkit.org/318974@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications