Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: daf27727d7fd9a01b5abda9bc9c3e6a956d5e8b8
https://github.com/WebKit/WebKit/commit/daf27727d7fd9a01b5abda9bc9c3e6a956d5e8b8
Author: Phinehas Fuachie <[email protected]>
Date: 2026-08-11 (Tue, 11 Aug 2026)
Changed paths:
M LayoutTests/http/tests/site-isolation/fullscreen-escape-key-expected.txt
M LayoutTests/http/tests/site-isolation/resources/fullscreen-escape-key.html
M LayoutTests/platform/mac-wk2/TestExpectations
Log Message:
-----------
[Site Isolation] http/tests/site-isolation/fullscreen-escape-key.html is a
flaky failure
https://bugs.webkit.org/show_bug.cgi?id=321262
rdar://184313220
Reviewed by Jean-Yves Avenard.
The cross-origin child requested fullscreen before its parent had assigned it a
frame rect.
A site-isolated child's frame view is sized from
ProvisionalFrameCreationParameters::initialRect,
which the UI process only has once the parent has broadcast a FrameRect
frame-tree sync
(WebPageProxy::broadcastFrameTreeSyncData ->
WebFrameProxy::setRemoteFrameRect); until that
arrives the child sits at the default 800x600 viewport instead of the 300x150
given to it by the
<iframe>. WebFullScreenManager::performEnterFullScreen samples the
pre-transition rect with no
barrier against that sync, so beganEnterFullScreen() reported 800x600 when the
request won the
race and the correct 300x150 when it lost, at a load-dependent 4-9% locally.
Wait for the parent-assigned size before requesting fullscreen so the
pre-transition rect is
sampled deterministically, and update the baseline to the pre-fullscreen
300x150. The previous
baseline recorded the raced value; the sizes now match
http/tests/site-isolation/fullscreen.html
and the non-site-isolated dumpFullScreenCallbacks() tests, which all report the
element's size
before the transition in initialRect.
* LayoutTests/http/tests/site-isolation/fullscreen-escape-key-expected.txt:
* LayoutTests/http/tests/site-isolation/resources/fullscreen-escape-key.html:
* LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/318986@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
