Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3e5ac6f71459be18c1d617357a2406171b419292
https://github.com/WebKit/WebKit/commit/3e5ac6f71459be18c1d617357a2406171b419292
Author: Jean-Yves Avenard <[email protected]>
Date: 2026-08-11 (Tue, 11 Aug 2026)
Changed paths:
M Source/WebKit/UIProcess/Media/RemoteMediaSessionManagerProxy.cpp
M Source/WebKit/UIProcess/Media/RemoteMediaSessionManagerProxy.h
M Source/WebKit/UIProcess/Media/RemoteMediaSessionManagerProxy.messages.in
M Source/WebKit/WebProcess/Media/RemoteMediaSessionManager.cpp
Log Message:
-----------
[site-isolation]
platform/mac/media/audio-session-category-video-track-change.html is an
intermittent failure
https://bugs.webkit.org/show_bug.cgi?id=321492
rdar://184587691
Reviewed by Eric Carlson.
The test enables a video's audio track while it plays and expects the audio
session category to become MediaPlayback. With site isolation enabled it read
None. internals.audioSessionCategory() reads the category cached in the web
process by RemoteAudioSession, and in that pass the web process never applied a
category at all: the UI process computed MediaPlayback and the GPU process
applied it to the audio session, while the web process hosting the page logged
no
setCategory.
AddMediaSession replies with the current category, mode and route sharing
policy,
and the web process applies the reply, so a session's process knows the category
from the moment the session registers. This follows UpdateMediaSessionStates and
MediaSessionWillBeginPlayback, which already reply with it.
The test remains intermittent for a separate reason: webkit.org/b/184609 makes
the
non-isolated run miss the same category change, and the comparison fails
whenever
that happens.
* Source/WebKit/UIProcess/Media/RemoteMediaSessionManagerProxy.cpp:
(WebKit::RemoteMediaSessionManagerProxy::addMediaSession): Reply with the
current
category.
* Source/WebKit/UIProcess/Media/RemoteMediaSessionManagerProxy.h:
* Source/WebKit/UIProcess/Media/RemoteMediaSessionManagerProxy.messages.in:
* Source/WebKit/WebProcess/Media/RemoteMediaSessionManager.cpp:
(WebKit::RemoteMediaSessionManager::addSession): Apply the category the reply
carries.
Canonical link: https://commits.webkit.org/319003@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
