Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: faa6c20ea181f947985389d1fe82b1eabebab231
https://github.com/WebKit/WebKit/commit/faa6c20ea181f947985389d1fe82b1eabebab231
Author: Jean-Yves Avenard <[email protected]>
Date: 2026-08-12 (Wed, 12 Aug 2026)
Changed paths:
M LayoutTests/media/track/track-in-band-cues-added-once.html
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac/TestExpectations
Log Message:
-----------
media/track/track-in-band-cues-added-once.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=142152
rdar://184667127
Reviewed by Eric Carlson.
The test plays a segment, collects the start times of the in-band cues delivered
so far, seeks back to the beginning, plays the same segment again and compares
the two lists by index. It reported cue N's start time as cue N-1's, for every
cue.
Which six cues the first pass collected depended on how far playback had got
when
its 100ms poll saw more than five of them. When the cue at 0.2002 had not been
delivered yet, the first pass collected 1.001 through 4.471133 instead, and the
replay delivered 0.2002 as the first cue, shifting every index by one. The cues
themselves were added once: the log shows the replay's cues being rejected by
addGenericCue()'s duplicate check, which is what the test is named for.
The test now checks that each cue collected before the replay is present exactly
once afterwards, rather than at the same index, and waits for the replay to
deliver the last cue it collected before comparing, since that cue may not have
been re-delivered when the list first reaches the collected length.
* LayoutTests/media/track/track-in-band-cues-added-once.html:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
Canonical link: https://commits.webkit.org/319058@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
