Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b330d0a4e971cbdd9bdba47877d5955c420cfa00
https://github.com/WebKit/WebKit/commit/b330d0a4e971cbdd9bdba47877d5955c420cfa00
Author: Qianlang Chen <[email protected]>
Date: 2026-08-12 (Wed, 12 Aug 2026)
Changed paths:
M LayoutTests/inspector/page/searchInResources.html
Log Message:
-----------
[Site Isolation] Web Inspector: searchInResources.html fails under Site
Isolation
rdar://184286094
https://bugs.webkit.org/show_bug.cgi?id=321239
Reviewed by BJ Burg.
Under Site Isolation, Page.searchInResources is implemented by
ProxyingPageAgent in the UIProcess. It fans the search out to every
WebContent process, and each process scans both its frames' cached
resources and its BackendResourceDataStore, which is where the buffered
XHR and Worker response bodies live.
The test reached the Page domain through the window.PageAgent global,
which resolves to WI.mainTarget's Page agent -- that is, the page
target's in-process InspectorPageAgent. That agent walks only its own
frame tree and delegates XHR and Worker bodies to
enabledNetworkAgent(). Under Site Isolation the legacy
InspectorNetworkAgent is never enabled, since FrameNetworkAgentProxy
and BackendResourceDataStore take its place, so that half of the search
was silently skipped: search-xhr.txt and search-worker.js were absent
from every SearchAllResources result, which in turn made the four
SearchInXHRResource cases reject.
Select the target that owns the live implementation, gating on
WI.networkManager.enabledPageForSiteIsolation the same way
WI.Resource.prototype.requestContentFromBackend already does. The
reported results are identical with and without Site Isolation, so the
expected results are unchanged.
Choosing the target per call site is a stopgap. Every window.*Agent
global resolves to the page target, which is the wrong destination for
the Page domain under Site Isolation in general; that will be handled
along with the removal of the window.*Agent globals, tracked by
webkit.org/b/201149.
* LayoutTests/inspector/page/searchInResources.html:
Now progresses with `run-webkit-tests --site-isolation`.
Canonical link: https://commits.webkit.org/319070@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
