Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ba82b6ab43cece22292e3912cc6e5c985b36b9c8
https://github.com/WebKit/WebKit/commit/ba82b6ab43cece22292e3912cc6e5c985b36b9c8
Author: Basuke Suzuki <[email protected]>
Date: 2026-08-14 (Fri, 14 Aug 2026)
Changed paths:
M Source/WebCore/PlatformCocoa.cmake
Log Message:
-----------
[CMake] Mac build fails to resolve the WebCore_Private module when
ENABLE_BACK_FORWARD_LIST_SWIFT is off
https://bugs.webkit.org/show_bug.cgi?id=321684
rdar://184829371
Reviewed by Zak Ridouh.
A macOS CMake build configured with --no-swift-back-forward-list fails with:
Source/WebKit/SwiftPrewarmMac.swift:27:8: error: unable to resolve module
dependency: 'WebCore_Private'
import WebCore_Private
^
note: a dependency of main module 'SwiftPrewarmMac'
319083@main added unconditional imports of the WebKit stack's own modules to
SwiftPrewarmMac.swift, including WebCore_Private. Staging the in-tree
WebCore_Private module map into the WebCore framework bundle -- where the Swift
Clang importer finds it via -F -- was gated on ENABLE_BACK_FORWARD_LIST_SWIFT,
so with that feature off WebCore.framework/Modules is left empty and the module
cannot be resolved.
The prewarm target is not gated on that feature: SWIFT_REQUIRED is
unconditionally ON for Cocoa, and Source/WebKit/CMakeLists.txt adds the target
for SWIFT_REQUIRED AND WEBKIT_SDK_IS_MACOS. Gate the staging on SWIFT_REQUIRED
instead, which matches the iOS path in the same file (it stages the map
unconditionally).
No new tests (build fix, no behavior change).
* Source/WebCore/PlatformCocoa.cmake:
Canonical link: https://commits.webkit.org/319166@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
