Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 53f0302b256e864a6a9cc9b5fcceb8bf177067a6
https://github.com/WebKit/WebKit/commit/53f0302b256e864a6a9cc9b5fcceb8bf177067a6
Author: Tim Horton <[email protected]>
Date: 2026-08-14 (Fri, 14 Aug 2026)
Changed paths:
M Source/WebKitLegacy/PlatformCocoa.cmake
M
Source/WebKitLegacy/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations
M Source/WebKitLegacy/SourcesCMakeCocoa.txt
M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj
M Source/WebKitLegacy/ios/WebView/WebPDFViewIOS.mm
M Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm
R Source/WebKitLegacy/mac/WebView/WebJSPDFDoc.h
R Source/WebKitLegacy/mac/WebView/WebJSPDFDoc.mm
M Source/WebKitLegacy/mac/WebView/WebPDFDocumentExtras.h
M Source/WebKitLegacy/mac/WebView/WebPDFDocumentExtras.mm
M Source/WebKitLegacy/mac/WebView/WebPDFRepresentation.mm
M Tools/MiniBrowser/mac/WK1BrowserWindowController.m
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
A Tools/TestWebKitAPI/Tests/WebKitLegacy/mac/PDFEmbeddedPrintScript.mm
Log Message:
-----------
Port 285037@main's simplified regex-based PDF script runner to WebPDFView
https://bugs.webkit.org/show_bug.cgi?id=321718
rdar://184618347
Reviewed by Abrar Rahman Protyasha.
* Source/WebKitLegacy/PlatformCocoa.cmake:
* Source/WebKitLegacy/SourcesCMakeCocoa.txt:
* Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj:
* Source/WebKitLegacy/mac/WebView/WebJSPDFDoc.h: Removed.
* Source/WebKitLegacy/mac/WebView/WebJSPDFDoc.mm: Removed.
* Source/WebKitLegacy/mac/WebView/WebPDFDocumentExtras.h:
* Source/WebKitLegacy/mac/WebView/WebPDFDocumentExtras.mm:
(isPrintScript):
(pdfDocumentContainsPrintScript):
(allScriptsInPDFDocument): Deleted.
* Source/WebKitLegacy/mac/WebView/WebPDFRepresentation.mm:
(-[WebPDFRepresentation finishedLoadingWithDataSource:]):
See 285037@main; don't spend time spinning up JSC just to see if the word
print() exists in the PDF's script. Port that change to WebKitLegacy's PDF view.
* Source/WebKitLegacy/ios/WebView/WebPDFViewIOS.mm:
(-[WebPDFView finishedLoadingWithDataSource:]):
* Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm:
(-[WebPDFViewPlaceholder _doPostLoadOrUnlockTasks]):
(-[WebPDFViewPlaceholder _printIfDocumentContainsPrintScript:]):
(-[WebPDFViewPlaceholder _evaluateJSForDocument:]): Deleted.
Same for iOS.
* Tools/MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController webView:printFrameView:]):
Also, drive-by make printing work in WebKitLegacy MiniBrowser.
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitLegacy/mac/PDFEmbeddedPrintScript.mm: Added.
(-[TestLegacyPDFPrintDelegate webView:printFrameView:]):
(-[TestLegacyPDFPrintDelegate waitForPrintFrameViewCall]):
(-[TestLegacyPDFPrintDelegate printFrameViewCallCount]):
(TestWebKitAPI::TEST(WebKitLegacy, PDFWithEmbeddedPrintScriptPrints)):
And add a test.
*
Source/WebKitLegacy/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations:
Canonical link: https://commits.webkit.org/319185@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
