Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 11c7bc44b1119e68b5ea42ef21dc71b5278b5eec
https://github.com/WebKit/WebKit/commit/11c7bc44b1119e68b5ea42ef21dc71b5278b5eec
Author: Zak Ridouh <[email protected]>
Date: 2026-08-14 (Fri, 14 Aug 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKContentExtensionStore.mm
Log Message:
-----------
[CMake] Fix macOS build broken with redefinition of 'alertCount' in
TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=321830
rdar://184972366
Reviewed by Simon Fraser.
WKContentExtensionStore.mm and WebsitePolicies.mm both declare a
file-scope `static size_t alertCount`. This has been latent since 2017
and only breaks when the two files share a unified source bundle.
319204@main added HTTP3Server.mm to SourcesCocoa.txt, which shifted the
bundle boundary and placed both files in
UnifiedSource-Tests-3-nonARC.mm. Xcode still builds because it uses the
default bundle size of 8, which keeps the files 11 bundles apart; the
CMake Cocoa build uses 128.
Rename the variable in WKContentExtensionStore.mm to match the
`contentExtensionReceivedAlert` flag next to it. No behavior change.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKContentExtensionStore.mm:
(-[ContentRuleListDelegate
webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST_F(WKContentRuleListStoreTest, AddRemove)):
Canonical link: https://commits.webkit.org/319214@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
