Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fc282b23c3fea8cf575b8ed8d6f43141b6fd655f
https://github.com/WebKit/WebKit/commit/fc282b23c3fea8cf575b8ed8d6f43141b6fd655f
Author: Taher Ali <[email protected]>
Date: 2026-08-15 (Sat, 15 Aug 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-link-params/inheritance-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-link-params/link-parameters-computed-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/css/css-link-params/link-parameters-substitution-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/css/css-link-params/link-parameters-substitution.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-link-params/link-parameters-valid-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/shadow-dom-expected.txt
M
LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M
LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/rendering/widgets/shadow-dom-expected.txt
M
LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/shadow-dom-expected.txt
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/CMakeLists.txt
M Source/WebCore/Headers.cmake
M Source/WebCore/SaferCPPExpectations/NoDeleteCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
A Source/WebCore/css/CSSParamValue.cpp
A Source/WebCore/css/CSSParamValue.h
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/CSSValue.cpp
M Source/WebCore/css/CSSValue.h
M Source/WebCore/css/CSSValueKeywords.in
A Source/WebCore/css/parser/CSSPropertyParserConsumer+LinkParameters.cpp
A Source/WebCore/css/parser/CSSPropertyParserConsumer+LinkParameters.h
M Source/WebCore/css/parser/CSSPropertyParserCustom.h
A Source/WebCore/css/values/link-params/CSSLinkParameter.h
A Source/WebCore/css/values/primitives/CSSDeclarationValue.cpp
A Source/WebCore/css/values/primitives/CSSDeclarationValue.h
M Source/WebCore/style/computed/StyleComputedStyleBase.h
M Source/WebCore/style/computed/data/StyleNonInheritedRareData.cpp
M Source/WebCore/style/computed/data/StyleNonInheritedRareData.h
A Source/WebCore/style/values/link-params/StyleLinkParameters.cpp
A Source/WebCore/style/values/link-params/StyleLinkParameters.h
A Source/WebCore/style/values/primitives/StyleDeclarationValue.cpp
A Source/WebCore/style/values/primitives/StyleDeclarationValue.h
Log Message:
-----------
[css-link-params] Add the link-parameters property
https://bugs.webkit.org/show_bug.cgi?id=321208
rdar://184267962
Reviewed by Sam Weinig.
The link-parameters property sets named values on the external resources an
element references, which the resource reads with env():
img { link-parameters: param(--color, green); }
This PR parses, computes and serializes the property. The computed value is not
used yet, so it has no rendering effect. That follows seperately.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-link-params/inheritance-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-link-params/link-parameters-computed-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-link-params/link-parameters-substitution-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-link-params/link-parameters-substitution.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-link-params/link-parameters-valid-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/shadow-dom-expected.txt:
*
LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
*
LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/rendering/widgets/shadow-dom-expected.txt:
*
LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/shadow-dom-expected.txt:
Rebaseline the already failed test. The test asserts
getComputedStyle(child).length is 0
for an element outside the flat tree; WebKit returns the property count instead.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/Headers.cmake:
* Source/WebCore/SaferCPPExpectations/NoDeleteCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSParamValue.cpp: Added.
(WebCore::CSSParamValue::CSSParamValue):
(WebCore::CSSParamValue::equals const):
(WebCore::CSSParamValue::customCSSText const):
* Source/WebCore/css/CSSParamValue.h: Added.
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValue.cpp:
(WebCore::CSSValue::visitDerived):
* Source/WebCore/css/CSSValue.h:
(WebCore::CSSValue::isParamValue const):
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+LinkParameters.cpp: Added.
(WebCore::CSSPropertyParserHelpers::consumeParamFunction):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+LinkParameters.h: Added.
* Source/WebCore/css/parser/CSSPropertyParserCustom.h:
* Source/WebCore/css/values/link-params/CSSLinkParameter.h: Added.
(WebCore::CSS::get):
* Source/WebCore/css/values/primitives/CSSDeclarationValue.cpp: Added.
(WebCore::CSS::DeclarationValue::operator== const):
(WebCore::CSS::Serialize<DeclarationValue>::operator):
(WebCore::CSS::operator<<):
* Source/WebCore/css/values/primitives/CSSDeclarationValue.h: Added.
(WebCore::CSS::ComputedStyleDependenciesCollector<DeclarationValue>::operator()):
(WebCore::CSS::CSSValueChildrenVisitor<DeclarationValue>::operator()):
* Source/WebCore/style/computed/StyleComputedStyleBase.h:
* Source/WebCore/style/computed/data/StyleNonInheritedRareData.cpp:
(WebCore::Style::NonInheritedRareData::NonInheritedRareData):
(WebCore::Style::NonInheritedRareData::operator== const):
(WebCore::Style::NonInheritedRareData::dumpDifferences const):
* Source/WebCore/style/computed/data/StyleNonInheritedRareData.h:
* Source/WebCore/style/values/link-params/StyleLinkParameters.cpp: Added.
(WebCore::Style::CSSValueConversion<LinkParameter>::operator):
(WebCore::Style::CSSValueCreation<LinkParameter>::operator):
* Source/WebCore/style/values/link-params/StyleLinkParameters.h: Added.
(WebCore::Style::get):
* Source/WebCore/style/values/primitives/StyleDeclarationValue.cpp: Added.
(WebCore::Style::DeclarationValue::operator== const):
(WebCore::Style::ToCSS<DeclarationValue>::operator):
(WebCore::Style::ToStyle<CSS::DeclarationValue>::operator):
(WebCore::Style::Serialize<DeclarationValue>::operator):
(WebCore::Style::operator<<):
* Source/WebCore/style/values/primitives/StyleDeclarationValue.h: Added.
Canonical link: https://commits.webkit.org/319240@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
