Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f082dfc9005c6a15d5bf43f6b21c5f4a3f234d53
      
https://github.com/WebKit/WebKit/commit/f082dfc9005c6a15d5bf43f6b21c5f4a3f234d53
  Author: Sam Weinig <[email protected]>
  Date:   2026-08-17 (Mon, 17 Aug 2026)

  Changed paths:
    M LayoutTests/fast/text/line-height-minimumFontSize-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-rem-expected.txt
    M Source/WebCore/style/StyleBuilderCustom.h
    M Source/WebCore/style/StyleBuilderState.cpp
    M Source/WebCore/style/values/primitives/StyleLengthResolution.cpp

  Log Message:
  -----------
  [EvaluationTimeZoom] Use the font's specifiedSize() getter consistently in 
length resolution
https://bugs.webkit.org/show_bug.cgi?id=321095

Reviewed by Darin Adler.

Use the computed font size (confusingly named specifiedSize()) rather than the
minimum-font-size adjusted size (confusingly called unzoomedComputedSize()) 
always
when computing `em`, `rem`, `ex` and `rex` units.

This matches what CSS Values 4 says to do:

  "Some user-agents allow users to apply additional restrictions to font sizes 
in a
   document, such as setting minimum font sizes to ensure readability. Such 
restrictions
   must be applied to the used value of the affected properties only; they must 
not
   affect the resolution of font-relative lengths used in properties"
    - https://drafts.csswg.org/css-values-4/#font-relative-length

The change whitespace change in line-height-minimumFontSize-expected.txt is due 
to the
margins around the description changing (due to 1em now being 16 and not 64px). 
The
dump-as-text code uses TextIterator, which has heuristic to add newlines that 
is based
on the used margins (see shouldEmitExtraNewlineForNode).

* LayoutTests/fast/text/line-height-minimumFontSize-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-rem-expected.txt:
* Source/WebCore/style/values/primitives/StyleLengthResolution.cpp:

Canonical link: https://commits.webkit.org/319340@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to