Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3400ff6aa7b63e840b7cecd229e38e2c19e538ae
      
https://github.com/WebKit/WebKit/commit/3400ff6aa7b63e840b7cecd229e38e2c19e538ae
  Author: Justin Michaud <[email protected]>
  Date:   2026-08-18 (Tue, 18 Aug 2026)

  Changed paths:
    A JSTests/wasm/stress/wasm-imported-string-constants-utf8.js
    M Source/JavaScriptCore/wasm/WasmModuleInformation.cpp
    M Source/JavaScriptCore/wasm/WasmModuleInformation.h
    M Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp

  Log Message:
  -----------
  Don't share StringImpl for worker names
https://bugs.webkit.org/show_bug.cgi?id=321818

Reviewed by Yusuke Suzuki.

Since not all fields of StringImpl are atomic yet, it is
better form to just not share them, even if this site is
benign

* JSTests/wasm/stress/wasm-imported-string-constants-utf8.js: Added.
(uleb):
(name):
(moduleWithGlobalImport):
(testMatch):
(testNoMatch):
(string_appeared_here.const.module.new.WebAssembly.Module.moduleWithGlobalImport):
* Source/JavaScriptCore/wasm/WasmModuleInformation.cpp:
(JSC::Wasm::encodeAsImportName):
(JSC::Wasm::ModuleInformation::applyCompileOptions):
(JSC::Wasm::ModuleInformation::populateImportShouldBeHidden):
* Source/JavaScriptCore/wasm/WasmModuleInformation.h:
* Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::findEnabledBuiltinSet):
(JSC::WebAssemblyModuleRecord::initializeImports):

Canonical link: https://commits.webkit.org/319371@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to