Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d5c5445db4d92f7b3e730d443334147ca81eb8b7
      
https://github.com/WebKit/WebKit/commit/d5c5445db4d92f7b3e730d443334147ca81eb8b7
  Author: Ben Nham <[email protected]>
  Date:   2026-08-18 (Tue, 18 Aug 2026)

  Changed paths:
    A 
LayoutTests/http/tests/site-isolation/animated-gif-in-cross-origin-iframe-created-while-hidden-expected.txt
    A 
LayoutTests/http/tests/site-isolation/animated-gif-in-cross-origin-iframe-created-while-hidden.html
    A 
LayoutTests/http/tests/site-isolation/animated-gif-in-cross-origin-iframe-of-hidden-page-expected.txt
    A 
LayoutTests/http/tests/site-isolation/animated-gif-in-cross-origin-iframe-of-hidden-page.html
    A 
LayoutTests/http/tests/site-isolation/animated-svg-image-in-cross-origin-iframe-created-while-hidden-expected.txt
    A 
LayoutTests/http/tests/site-isolation/animated-svg-image-in-cross-origin-iframe-created-while-hidden.html
    A 
LayoutTests/http/tests/site-isolation/animated-svg-image-in-cross-origin-iframe-of-hidden-page-expected.txt
    A 
LayoutTests/http/tests/site-isolation/animated-svg-image-in-cross-origin-iframe-of-hidden-page.html
    A 
LayoutTests/http/tests/site-isolation/muted-autoplay-in-cross-origin-iframe-created-while-hidden-expected.txt
    A 
LayoutTests/http/tests/site-isolation/muted-autoplay-in-cross-origin-iframe-created-while-hidden.html
    A LayoutTests/http/tests/site-isolation/resources/animated-image-frame.html
    A 
LayoutTests/http/tests/site-isolation/resources/animated-red-green-blue-repeat-infinite.gif
    A LayoutTests/http/tests/site-isolation/resources/muted-autoplay-frame.html
    A LayoutTests/http/tests/site-isolation/resources/smil-animation.svg
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/Page.h

  Log Message:
  -----------
  [Site Isolation] Animated images do not stop in an out-of-process iframe of a 
hidden page
https://bugs.webkit.org/show_bug.cgi?id=321891
rdar://185064757

Reviewed by Simon Fraser.

When Site Isolation is enabled, we skipped over several operations in 
out-of-process iframes,
because they only applied when a local main frame was present:

 - resuming animated images
 - calling show/hide on LocalFrameView roots (which affects scroll view state 
and tiled backing
   coverage)

(The path the pauses animated images isn't affected here--the animated image 
timer loop already
self-pause when the images being animated go offscreen.)

Fix this by making this logic iterate through all root views rather than 
applying to just the main
local frame view.

* 
LayoutTests/http/tests/site-isolation/animated-gif-in-cross-origin-iframe-created-while-hidden-expected.txt:
 Added.
* 
LayoutTests/http/tests/site-isolation/animated-gif-in-cross-origin-iframe-created-while-hidden.html:
 Added.
* 
LayoutTests/http/tests/site-isolation/animated-gif-in-cross-origin-iframe-of-hidden-page-expected.txt:
 Added.
* 
LayoutTests/http/tests/site-isolation/animated-gif-in-cross-origin-iframe-of-hidden-page.html:
 Added.
* 
LayoutTests/http/tests/site-isolation/animated-svg-image-in-cross-origin-iframe-created-while-hidden-expected.txt:
 Added.
* 
LayoutTests/http/tests/site-isolation/animated-svg-image-in-cross-origin-iframe-created-while-hidden.html:
 Added.
* 
LayoutTests/http/tests/site-isolation/animated-svg-image-in-cross-origin-iframe-of-hidden-page-expected.txt:
 Added.
* 
LayoutTests/http/tests/site-isolation/animated-svg-image-in-cross-origin-iframe-of-hidden-page.html:
 Added.
* 
LayoutTests/http/tests/site-isolation/muted-autoplay-in-cross-origin-iframe-created-while-hidden-expected.txt:
 Added.
* 
LayoutTests/http/tests/site-isolation/muted-autoplay-in-cross-origin-iframe-created-while-hidden.html:
 Added.
* LayoutTests/http/tests/site-isolation/resources/animated-image-frame.html: 
Added.
* 
LayoutTests/http/tests/site-isolation/resources/animated-red-green-blue-repeat-infinite.gif:
 Added.
* LayoutTests/http/tests/site-isolation/resources/muted-autoplay-frame.html: 
Added.
* LayoutTests/http/tests/site-isolation/resources/smil-animation.svg: Added.
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::show):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::resumeAnimatingImages):
(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::forEachRootFrameView):
* Source/WebCore/page/Page.h:

Canonical link: https://commits.webkit.org/319373@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to