Title: [115601] trunk/Tools
Revision
115601
Author
[email protected]
Date
2012-04-29 18:22:08 -0700 (Sun, 29 Apr 2012)

Log Message

REGRESSION: On Lion, run-webkit-tests changes the display color profile even when not running pixel tests
https://bugs.webkit.org/show_bug.cgi?id=81729

Reviewed by Dan Bernstein.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._set_up_run): Only launch LayoutTestHelper when running pixel tests.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (115600 => 115601)


--- trunk/Tools/ChangeLog	2012-04-30 00:25:56 UTC (rev 115600)
+++ trunk/Tools/ChangeLog	2012-04-30 01:22:08 UTC (rev 115601)
@@ -1,3 +1,13 @@
+2012-04-29  Maciej Stachowiak  <[email protected]>
+
+        REGRESSION: On Lion, run-webkit-tests changes the display color profile even when not running pixel tests
+        https://bugs.webkit.org/show_bug.cgi?id=81729
+
+        Reviewed by Dan Bernstein.
+
+        * Scripts/webkitpy/layout_tests/controllers/manager.py:
+        (Manager._set_up_run): Only launch LayoutTestHelper when running pixel tests.
+
 2012-04-29  Sudarsana Nagineni  <[email protected]>
 
         [GTK] DRT needs an implementation of layoutTestController.setDomainRelaxationForbiddenForURLScheme

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (115600 => 115601)


--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py	2012-04-30 00:25:56 UTC (rev 115600)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py	2012-04-30 01:22:08 UTC (rev 115601)
@@ -846,8 +846,9 @@
         """
         # This must be started before we check the system dependencies,
         # since the helper may do things to make the setup correct.
-        self._printer.print_update("Starting helper ...")
-        self._port.start_helper()
+        if self._options.pixel_tests:
+            self._printer.print_update("Starting pixel test helper ...")
+            self._port.start_helper()
 
         # Check that the system dependencies (themes, fonts, ...) are correct.
         if not self._options.nocheck_sys_deps:
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to