Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8ea696080a81725a5ec108c4982bca863824a40f
https://github.com/WebKit/WebKit/commit/8ea696080a81725a5ec108c4982bca863824a40f
Author: Diego Pino Garcia <[email protected]>
Date: 2026-08-18 (Tue, 18 Aug 2026)
Changed paths:
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h
M Source/WebCore/accessibility/atspi/AccessibilityObjectValueAtspi.cpp
M
Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp
Log Message:
-----------
[GLIB] accessibility/keyevents-posted-for-increment-actions.html times out
https://bugs.webkit.org/show_bug.cgi?id=213874
Reviewed by Patrick Griffis.
GLIB ports have a custom implementation for increment/decrement actions,
which directly sets a value on the underlying backing object.
On the other hand, macOS and iOS ports use the increment/decrement methods
provided by 'AccessibilityNodeObject'. These operations are more complex than
simply updating the value of the backing object (for instance, in the case of
a slider, a keyboard event is emitted instead).
The test hangs on GLIB ports because their current implementation never emits
this keyboard event.
Since increment/decrement live in 'AccessibilityNodeObject', this patch modifies
the GLIB implementation to reuse the same general implementation used by the
macOS and iOS ports, which fixes the timeout in the targetting tests.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h:
* Source/WebCore/accessibility/atspi/AccessibilityObjectValueAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::increment):
(WebCore::AccessibilityObjectAtspi::decrement):
* Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::AccessibilityUIElementAtspi::increment):
(WTR::AccessibilityUIElementAtspi::decrement):
Canonical link: https://commits.webkit.org/319432@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
