Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a4cbb7e2164123007c62e1d2c9cd39d194f57233
https://github.com/WebKit/WebKit/commit/a4cbb7e2164123007c62e1d2c9cd39d194f57233
Author: Diego Pino Garcia <[email protected]>
Date: 2026-08-19 (Wed, 19 Aug 2026)
Changed paths:
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h
M
Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp
M Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.h
Log Message:
-----------
[GLIB][a11y] WTR: Add missing implementation of focusableAncestor
https://bugs.webkit.org/show_bug.cgi?id=322094
Reviewed by Carlos Garcia Campos.
Changeset 258327@main refactored properties 'FocusableAncestor',
'EditableAncestor' and 'HighestEditableAncestor' to resolve them on demand.
A working implementation for macOS/iOS port was added but an equivalent
implementation for GLIB ports was missing.
The core implementation for this functionality is shared across ports, living
in 'AXCoreObject.h'. The patch implements the required WKTR interface methods
on GLIB ('focusableAncestor', 'editableAncestor', etc), which end up
calling the 'AXCoreObject' methods via 'AccessibilityObjectAtspi'.
Also, the condition in 'accessibilityPlatformIncludesObject' that
ignores children of text controls has been relaxed for content-editable
controls, since they can contain valid non-text descendants (such as
a button). Otherwise, 'editableAncestor' would return an ignored object.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::focusableAncestor const):
(WebCore::AccessibilityObjectAtspi::editableAncestor const):
(WebCore::AccessibilityObjectAtspi::highestEditableAncestor const):
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject const):
(WebCore::AccessibilityObjectAtspi::states const):
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h:
* Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::AccessibilityUIElementAtspi::focusableAncestor):
(WTR::AccessibilityUIElementAtspi::editableAncestor):
(WTR::AccessibilityUIElementAtspi::highestEditableAncestor):
* Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.h:
Canonical link: https://commits.webkit.org/319449@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
