Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e8eea7b9bf07ecbaf4b1d539cbb0c586bf41e605
https://github.com/WebKit/WebKit/commit/e8eea7b9bf07ecbaf4b1d539cbb0c586bf41e605
Author: Claudio Saavedra <[email protected]>
Date: 2026-08-19 (Wed, 19 Aug 2026)
Changed paths:
M Source/WebKit/PlatformGTK.cmake
M Source/WebKit/Scripts/generate-serializers.py
M Source/WebKit/Shared/PrintInfo.serialization.in
R Source/WebKit/Shared/gtk/ArgumentCodersGtk.cpp
R Source/WebKit/Shared/gtk/ArgumentCodersGtk.h
A Source/WebKit/Shared/gtk/ArgumentCodersGtk.serialization.in
A Source/WebKit/Shared/gtk/CoreIPCGtkPrint.cpp
A Source/WebKit/Shared/gtk/CoreIPCGtkPrint.h
M Source/WebKit/SourcesGTK.txt
M Source/WebKit/WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
Log Message:
-----------
[GTK] Generate serializers for GTK printing-related classes
https://bugs.webkit.org/show_bug.cgi?id=317928
Reviewed by Michael Catanzaro.
Let's start moving away from handcrafted serializers for the GLib/GObject
structs and classes. This can serve as an example of how to do this in
general.
GeneratedSerializers.h now includes <wtf/glib/GRefPtr.h> under USE(GLIB),
and the forward-declaration logic skips GRefPtr: unlike RetainPtr it has a
second (defaulted) template parameter, so the generated single-parameter
forward declaration would conflict with the real one. This special-case is
temporary; it goes away once GRefPtr is handled as a proper smart-pointer
family (keyed on the wrapped type rather than GRefPtr<T>), which will be
done in a separate PR.
* Source/WebKit/PlatformGTK.cmake:
* Source/WebKit/Scripts/generate-serializers.py:
(generate_forward_declarations):
(generate_header):
* Source/WebKit/Shared/PrintInfo.serialization.in:
* Source/WebKit/Shared/gtk/ArgumentCodersGtk.cpp: Removed.
* Source/WebKit/Shared/gtk/ArgumentCodersGtk.serialization.in: Added.
* Source/WebKit/Shared/gtk/CoreIPCGtkPrint.cpp: Copied from
Source/WebKit/Shared/gtk/ArgumentCodersGtk.h.
(WebKit::CoreIPCGtkPrintSettings::CoreIPCGtkPrintSettings):
(WebKit::CoreIPCGtkPrintSettings::operator GRefPtr<GtkPrintSettings> const):
(WebKit::CoreIPCGtkPageSetup::CoreIPCGtkPageSetup):
(WebKit::CoreIPCGtkPageSetup::operator GRefPtr<GtkPageSetup> const):
* Source/WebKit/Shared/gtk/CoreIPCGtkPrint.h: Renamed from
Source/WebKit/Shared/gtk/ArgumentCodersGtk.h.
(WebKit::CoreIPCGtkPrintSettings::CoreIPCGtkPrintSettings):
(WebKit::CoreIPCGtkPrintSettings::settings const):
(WebKit::CoreIPCGtkPageSetup::CoreIPCGtkPageSetup):
(WebKit::CoreIPCGtkPageSetup::pageSetup const):
* Source/WebKit/SourcesGTK.txt:
* Source/WebKit/WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
* Source/WebKit/WebProcess/WebPage/WebPage.h:
Canonical link: https://commits.webkit.org/319454@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
