Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c8774020913be0fbd355d7e147e1f48389d1ce55
https://github.com/WebKit/WebKit/commit/c8774020913be0fbd355d7e147e1f48389d1ce55
Author: Diego Pino Garcia <[email protected]>
Date: 2026-08-21 (Fri, 21 Aug 2026)
Changed paths:
M LayoutTests/inspector/heap/getRemoteObject.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations
Log Message:
-----------
inspector/heap/getRemoteObject.html is a flaky text failure
https://bugs.webkit.org/show_bug.cgi?id=315925
Reviewed by Alexey Proskuryakov.
At the moment of running the test 'GetRemoteObjectCollectedObject', the
'maps' collection always contains two elements. The code assummes that
it's always the element in 'maps' with the highest 'id' the one who
corresponds to the global object 'myMap', the target object the test
needs to later inspect.
The test was flaky because the heuristic to retrieve the
'myMap' object was not correct and sometimes the other map object in the
collection was returned instead. Since that object still exists, the test
fails.
The test has been refactored to guarantee always the 'myMap' object is
returned. To do that, the collection of retainer objects is iterated.
The property or variable object with name equals to 'myMap' will be the
one used for inspection.
* LayoutTests/inspector/heap/getRemoteObject.html:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/319586@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
