Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4f28f72d3c957b2fe1ee7e28dd6ab4e604273d3f
https://github.com/WebKit/WebKit/commit/4f28f72d3c957b2fe1ee7e28dd6ab4e604273d3f
Author: Tim Nguyen <[email protected]>
Date: 2026-08-21 (Fri, 21 Aug 2026)
Changed paths:
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
Log Message:
-----------
[Site Isolation] cnn.com "Sign-in with Google" popup displays with top
content cut off
https://bugs.webkit.org/show_bug.cgi?id=322202
rdar://168622112
Reviewed by Simon Fraser, Wenson Hsieh, Sihui Liu, and Abrar Rahman Protyasha.
When going to https://www.cnn.com/account/log-in and then clicking "Continue
with Google", WebKit initially opens a popup
in the same process as cnn.com, but then does a process swap to google.com.
When the process swap is performed, the top content
inset is not carried over, resulting in the top part of the popup getting
cut-off.
Fix this by carrying over the content insets in WebPage::reinitializeWebPage
when swapping processes.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::obscuredContentInsetTop):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::reinitializeWebPage):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation,
ObscuredContentInsetsSurviveWindowOpenProcessSwap)):
Canonical link: https://commits.webkit.org/319607@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
