Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3b9afb2b4f23fc2eb9555835a2ce0c6ebdb26056
https://github.com/WebKit/WebKit/commit/3b9afb2b4f23fc2eb9555835a2ce0c6ebdb26056
Author: Yusuke Suzuki <[email protected]>
Date: 2026-08-21 (Fri, 21 Aug 2026)
Changed paths:
A JSTests/wasm/stress/ref-cast-null-without-fault-signal-handler.js
A JSTests/wasm/stress/signaling-memory-large-offset-bounds-check.js
M Source/JavaScriptCore/b3/B3LowerMacros.cpp
M Source/JavaScriptCore/wasm/WasmBBQJIT.h
M Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp
M Source/JavaScriptCore/wasm/WasmBBQJIT64.h
M Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp
Log Message:
-----------
[JSC] Fix boundary related code in BBQ / OMG
https://bugs.webkit.org/show_bug.cgi?id=322255
rdar://185488178
Reviewed by Yijia Huang.
1. ref.cast's trapping null check should be used only when
Options::useWasmFaultSignalHandler() is true. (in practice, currently
all wasm environment is having useWasmFaultSignalHandler = true).
2. Instead of offset, we should use boundary for check skipping. But
actually this does not matter in practice since we end up crossing
trapping zone, so anyway, we get a trap correctly. But anyway,
computation was slightly wrong and slightly conservative.
Tests: JSTests/wasm/stress/ref-cast-null-without-fault-signal-handler.js
JSTests/wasm/stress/signaling-memory-large-offset-bounds-check.js
* JSTests/wasm/stress/ref-cast-null-without-fault-signal-handler.js: Added.
* JSTests/wasm/stress/signaling-memory-large-offset-bounds-check.js: Added.
(loadExpression):
(instantiateForPages):
(async testPages):
(async test):
* Source/JavaScriptCore/b3/B3LowerMacros.cpp:
* Source/JavaScriptCore/wasm/WasmBBQJIT.h:
(JSC::Wasm::BBQJITImpl::BBQJIT::emitCheckAndPreparePointer):
* Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::emitRefTestOrCast):
* Source/JavaScriptCore/wasm/WasmBBQJIT64.h:
(JSC::Wasm::BBQJITImpl::BBQJIT::emitCheckAndPrepareAndMaterializePointerApply):
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp:
(JSC::Wasm::OMGIRGenerator::emitCheckAndPreparePointer):
Canonical link: https://commits.webkit.org/319621@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
