Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bc9f76805019f00c439c5b5cc4fa197b5fc4cc1a
https://github.com/WebKit/WebKit/commit/bc9f76805019f00c439c5b5cc4fa197b5fc4cc1a
Author: Jean-Yves Avenard <[email protected]>
Date: 2026-08-23 (Sun, 23 Aug 2026)
Changed paths:
M Source/JavaScriptCore/PlatformCocoa.cmake
M Source/WebCore/PlatformCocoa.cmake
M Source/WebGPU/WebGPU/CMakeLists.txt
M Source/WebKit/PlatformCocoa.cmake
M Source/WebKitLegacy/PlatformCocoa.cmake
M Source/cmake/OptionsCocoa.cmake
M Tools/Scripts/webkitdirs.pm
Log Message:
-----------
[cmake] Provide ability to run Safari with webkit built by cmake
https://bugs.webkit.org/show_bug.cgi?id=322249
rdar://185482522
Reviewed by Zak Ridouh.
Make --cmake option given to run-safari works.
Couple of issues with the cmake webkit build that prevented Safari to start:
- compatibility version returned was 0.0.0 instead of the required 1.0.0
- Some swift overlays were missing from the cmake files, so some symbols loaded
by Safari were missing.
The macOS Swift module staging target is named WebKit_StageSwiftModuleMac, as
the
iOS family section of PlatformCocoa.cmake already defines
WebKit_StageSwiftModule.
Manually tested with run-safari --release --cmake
* Source/JavaScriptCore/PlatformCocoa.cmake:
* Source/WebCore/PlatformCocoa.cmake:
* Source/WebGPU/WebGPU/CMakeLists.txt:
* Source/WebKit/PlatformCocoa.cmake:
* Source/WebKitLegacy/PlatformCocoa.cmake:
* Source/cmake/OptionsCocoa.cmake:
* Tools/Scripts/webkitdirs.pm:
(determineArchitecture):
(argumentsForConfiguration):
(xcodeConfigurationProductDir): Where Xcode builds for the current
configuration; also used by determineConfigurationProductDir so the two can't
drift.
(determineConfigurationProductDir):
(safariPath):
(printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
(prependMacWebKitDyldPaths):
(setupMacWebKitEnvironment):
(dyldFrameworkPathsForMacWebKitApp):
(runMacWebKitApp):
(execMacWebKitAppForDebugging): Use the same framework path list as
runMacWebKitApp, so debug-safari --cmake finds Safari's own frameworks too.
Canonical link: https://commits.webkit.org/319673@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
