Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f8a5ceefaa5c731bcc2ac9d986be53d34dc9e594
https://github.com/WebKit/WebKit/commit/f8a5ceefaa5c731bcc2ac9d986be53d34dc9e594
Author: Issac Roy <[email protected]>
Date: 2026-08-24 (Mon, 24 Aug 2026)
Changed paths:
M Tools/CISupport/ews-build/factories.py
M Tools/CISupport/ews-build/factories_unittest.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
EWS does not record the architecture or WebKit version needed to upload
results to results.webkit.org
rdar://183782709
https://bugs.webkit.org/show_bug.cgi?id=320775
Reviewed by Sam Sneddon.
results.webkit.org identifies a configuration by platform, version and
architecture, and rejects an upload that cannot supply all three. EWS knows
neither reliably: architecture comes from the builder configuration, which
names what a build queue produces rather than what a tester ran on, so the
macOS-Sequoia testers inherit both x86_64 and arm64 and describe a machine
that does not exist. GTK and WPE have no OS version worth recording at all,
since what identifies a glib result is the port release.
Read the architecture from the machine itself, via uname -m in
PrintConfiguration, mapping aarch64 to the arm64 spelling results.webkit.org
stores. Read the port release from SET_PROJECT_VERSION in the checkout's
Options{GTK,WPE}.cmake, as its own step: the version comes from the source
tree, so a failure to resolve a commit identifier says nothing about whether
it can be read, and neither failure should hide the other. Both are best
effort, since nothing else in the build depends on either and a queue that
cannot describe itself simply does not report.
* Tools/CISupport/ews-build/factories.py:
(Factory.__init__):
(StyleFactory.__init__):
(SaferCPPStaticAnalyzerFactory.__init__):
(CommitQueueFactory.__init__):
(MergeQueueFactoryBase.__init__):
* Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/ews-build/steps.py:
(ShowWebKitVersion):
(ShowWebKitVersion.__init__):
(ShowWebKitVersion.doStepIf):
(ShowWebKitVersion.hideStepIf):
(ShowWebKitVersion.run):
(ShowWebKitVersion.getResultSummary):
(PrintConfiguration):
(PrintConfiguration.parseAndValidate):
* Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/319744@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
