Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 66328c1f5db75fc96954b1e3e960f6cf0cb39e40
      
https://github.com/WebKit/WebKit/commit/66328c1f5db75fc96954b1e3e960f6cf0cb39e40
  Author: Chris Dumez <[email protected]>
  Date:   2026-08-24 (Mon, 24 Aug 2026)

  Changed paths:
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj

  Log Message:
  -----------
  WKAttachmentTests and MediaLoading API tests are not built in the Xcode build
https://bugs.webkit.org/show_bug.cgi?id=322378

Reviewed by Richard Robinson.

The TestWebKitAPILibrary target has no fileSystemSynchronizedGroups entry, so 
the
synchronized Tests folder contributes nothing to it by default and its
membershipExceptions list is an opt-in list of the files compiled directly.
Everything else reaches the target through the UnifiedSourceN bundles generated
from Sources.txt and SourcesCocoa.txt, which means a file marked @no-unify has 
to
appear in membershipExceptions or it is not compiled at all.

310630@main dropped WebKit/WKWebView/MediaLoading.mm and
WebKit/WKWebView/WKAttachmentTests.mm from that list, so 41 WKAttachmentTests, 
11
WKAttachmentTestsMac and 5 MediaLoading tests have silently not been built or 
run
in the Xcode build since. Add them back. Only the Xcode build was affected; the
CMake ports read Sources*.txt directly and handle @no-unify themselves.

All 57 tests pass with the files restored.

* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/319762@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to