Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b62ea5f7bcc9d2e2aef56bdc63faf2c2f85189b8
https://github.com/WebKit/WebKit/commit/b62ea5f7bcc9d2e2aef56bdc63faf2c2f85189b8
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-08-25 (Tue, 25 Aug 2026)
Changed paths:
A
LayoutTests/platform/glib/damage/animations-opacity-with-descendant-layer-expected.txt
A
LayoutTests/platform/glib/damage/animations-opacity-with-descendant-layer.html
A LayoutTests/platform/glib/damage/layer-blend-mode-change-expected.txt
A LayoutTests/platform/glib/damage/layer-blend-mode-change.html
A
LayoutTests/platform/glib/damage/layer-opacity-change-with-descendant-layer-expected.txt
A
LayoutTests/platform/glib/damage/layer-opacity-change-with-descendant-layer.html
M Source/WebCore/platform/graphics/skia/SkiaCompositingLayer.cpp
M Source/WebCore/platform/graphics/skia/SkiaCompositingLayer.h
Log Message:
-----------
[GTK][WPE][Damage] opacity animation doesn't damage descendant layers
https://bugs.webkit.org/show_bug.cgi?id=316052
Reviewed by Carlos Garcia Campos.
Opacity applies to the whole group it composites, but SkiaCompositingLayer
only damaged the layer itself, so a descendant layer painting outside the
layer bounds kept its stale pixels.
Masks used to have the same issue, and we solved it by introduced
a m_maskChanged flag and mask-specific damage collector. Generalize both into
one m_groupPropertyChanged flag, set through groupPropertyChanged() by every
property that decides how the group is composited: opacity, filter, mask
blend mode and replica. collectGroupDamage() now damages the layer
plus the overlap region of its subtree, which fixes the problem.
Added new GTK/WPE specific damage tests, where coverage was missing.
*
LayoutTests/platform/glib/damage/animations-opacity-with-descendant-layer-expected.txt:
Added.
*
LayoutTests/platform/glib/damage/animations-opacity-with-descendant-layer.html:
Added.
* LayoutTests/platform/glib/damage/layer-blend-mode-change-expected.txt: Added.
* LayoutTests/platform/glib/damage/layer-blend-mode-change.html: Added.
*
LayoutTests/platform/glib/damage/layer-opacity-change-with-descendant-layer-expected.txt:
Added.
*
LayoutTests/platform/glib/damage/layer-opacity-change-with-descendant-layer.html:
Added.
* Source/WebCore/platform/graphics/skia/SkiaCompositingLayer.cpp:
(WebCore::SkiaCompositingLayer::setOpacity):
(WebCore::SkiaCompositingLayer::setBlendMode):
(WebCore::SkiaCompositingLayer::setMask):
(WebCore::SkiaCompositingLayer::setReplica):
(WebCore::SkiaCompositingLayer::setFilters):
(WebCore::SkiaCompositingLayer::opacityForAnimationsState const):
(WebCore::SkiaCompositingLayer::opacity const):
(WebCore::SkiaCompositingLayer::syncAnimations):
(WebCore::SkiaCompositingLayer::addGroupDamage):
(WebCore::SkiaCompositingLayer::collectGroupDamage):
(WebCore::SkiaCompositingLayer::paintWithMaskAndBackdrop):
(WebCore::SkiaCompositingLayer::paintWithFilterAndMask):
(WebCore::SkiaCompositingLayer::recursiveCleanUpAfterPaint):
(WebCore::SkiaCompositingLayer::collectMaskDamage): Deleted.
* Source/WebCore/platform/graphics/skia/SkiaCompositingLayer.h:
Canonical link: https://commits.webkit.org/319773@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
