Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a562b34e5386c35648835584439534662ce6b4a2
https://github.com/WebKit/WebKit/commit/a562b34e5386c35648835584439534662ce6b4a2
Author: Diego Pino Garcia <[email protected]>
Date: 2026-08-25 (Tue, 25 Aug 2026)
Changed paths:
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/platform/graphics/skia/ComplexTextControllerSkia.cpp
Log Message:
-----------
[Skia] Test fast/writing-mode/vertical-subst-font-vert-no-dflt.html is failing
https://bugs.webkit.org/show_bug.cgi?id=273477
Reviewed by Carlos Garcia Campos.
WebKit shapes vertical writing-mode text as an ordinary horizontal HarfBuzz
buffer (LTR/RTL direction) and relies on the font's OpenType 'vert'/'vrt2'
GSUB features to substitute glyphs with their vertical forms. HarfBuzz only
auto-enables 'vert'/'vrt2' for buffers shaped in a vertical direction (TTB/BTT),
which WebKit never uses. Thus, 'ComplexTextControllerSkia' must request
these features explicitly (otherwise vertical glyph substitution won't happen).
Fix by explicitly requesting 'vert'/'vrt2' whenever the font is vertically
oriented. Also add 'findScriptForVerticalGlyphSubstitution()', almost
identical to Harfbuzz's implementation, which looks up in which script the font
actually registers 'vert' and 'vrt2' and uses that script for shaping.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/graphics/skia/ComplexTextControllerSkia.cpp:
(WebCore::findScriptForVerticalGlyphSubstitution):
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
Canonical link: https://commits.webkit.org/319783@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
