Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 396f000caabcc215d7cce0ffc5f5663352812a38
https://github.com/WebKit/WebKit/commit/396f000caabcc215d7cce0ffc5f5663352812a38
Author: Ahmad Saleem <[email protected]>
Date: 2026-08-25 (Tue, 25 Aug 2026)
Changed paths:
M
Source/WebCore/Modules/pictureinpicture/HTMLVideoElementPictureInPicture.cpp
M Source/WebCore/Modules/pictureinpicture/HTMLVideoElementPictureInPicture.h
Log Message:
-----------
Remove dead autoPictureInPicture/disablePictureInPicture accessors in
HTMLVideoElementPictureInPicture
https://bugs.webkit.org/show_bug.cgi?id=322463
rdar://185751998
Reviewed by Jean-Yves Avenard.
HTMLVideoElement+PictureInPicture.idl declares both autoPictureInPicture and
disablePictureInPicture as [Reflect], so the generated bindings read and write
the content attribute directly on HTMLVideoElement:
impl.hasAttributeWithoutSynchronization(HTMLNames::autopictureinpictureAttr)
impl.setBooleanAttribute(HTMLNames::autopictureinpictureAttr, ...)
Nothing has called the four static accessors on the supplement since
216923@main added [Reflect] without removing them, and m_autoPictureInPicture
/ m_disablePictureInPicture have been state that nobody reads. Remove all six.
Also remove m_eventTaskGroup, which is never referenced anywhere - the class
queues its enterpictureinpicture and leavepictureinpicture tasks through
ActiveDOMObject::queueTaskKeepingObjectAlive() - along with the now-unneeded
CancellableTask.h include.
No behavior change, so no new tests.
* Source/WebCore/Modules/pictureinpicture/HTMLVideoElementPictureInPicture.cpp:
(WebCore::HTMLVideoElementPictureInPicture::autoPictureInPicture): Deleted.
(WebCore::HTMLVideoElementPictureInPicture::setAutoPictureInPicture): Deleted.
(WebCore::HTMLVideoElementPictureInPicture::disablePictureInPicture):
Deleted.
(WebCore::HTMLVideoElementPictureInPicture::setDisablePictureInPicture):
Deleted.
* Source/WebCore/Modules/pictureinpicture/HTMLVideoElementPictureInPicture.h:
Canonical link:
https://flagged.apple.com:443/proxy?t2=Db9R6Z0Ki8&o=aHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvMzE5Nzk3QG1haW4=&emid=c030eed0-9793-4c1a-9507-819a63f9f992&c=11
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
